Skip to content

Commit 8d7eb9b

Browse files
committed
Add issue link to testcase.
Refactor variable name.
1 parent d4c74a8 commit 8d7eb9b

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

catroidUiTest/src/org/catrobat/catroid/uitest/ui/ScriptFragmentTest.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,8 @@ public void testBrickCategoryDialog() {
162162
}
163163

164164
/**
165-
* Tests issue#54.
165+
*
166+
* Tests issue#54. https://github.com/Catrobat/Catroid/issues/54
166167
*/
167168
public void testOnlyAddControlBricks() {
168169
initEmptyProject();
@@ -177,7 +178,7 @@ public void testOnlyAddControlBricks() {
177178
solo.clickOnScreen(20, yPositionList.get(1));
178179
solo.sleep(200);
179180

180-
assertEquals("Two controll bricks should be added.", 2, sprite.getNumberOfScripts());
181+
assertEquals("Two control bricks should be added.", 2, sprite.getNumberOfScripts());
181182
assertTrue("First script isn't a start script.", sprite.getScript(0) instanceof StartScript);
182183
assertTrue("Second script isn't a broadcast script.", sprite.getScript(1) instanceof BroadcastScript);
183184
}

catroidUiTest/src/org/catrobat/catroid/uitest/util/UiTestUtils.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -642,10 +642,10 @@ public static ArrayList<Integer> getListItemYPositions(final Solo solo) {
642642
}
643643

644644
public static int getAddedListItemYPosition(Solo solo) {
645-
ArrayList<Integer> yPositionList = getListItemYPositions(solo);
646-
int pos = yPositionList.size() / 2;
645+
ArrayList<Integer> yPositionsList = getListItemYPositions(solo);
646+
int middleYPositionIndex = yPositionsList.size() / 2;
647647

648-
return yPositionList.get(pos);
648+
return yPositionsList.get(middleYPositionIndex);
649649
}
650650

651651
public static void longClickAndDrag(final Solo solo, final float xFrom, final float yFrom, final float xTo,

0 commit comments

Comments
 (0)