refactoring of layout xml

tried to remove warnings in activity_soundrecorder.xml
refactored ids

Author: kaufi

catroid/res/layout/activity_soundrecorder.xml

@@ -19,10 +19,10 @@
  *  GNU Affero General Public License for more details.
  *  
  *  You should have received a copy of the GNU Affero General Public License
- *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
--->
+ *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ -->
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-    android:id="@+id/SoundrecorderActivityRoot"
+    android:id="@+id/soundrecorder"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
     android:background="@android:color/white"
@@ -38,26 +38,26 @@
         android:textColor="@color/dark_gray" />
 
     <ImageView
-        android:id="@+id/recordButton"
+        android:id="@+id/soundrecorder_imageview_record"
         android:layout_width="wrap_content"
         android:layout_height="80dip"
         android:layout_gravity="center_horizontal"
         android:background="@android:color/transparent"
         android:src="@drawable/ic_record_inactive" />
 
     <TextView
-        android:id="@+id/recording"
+        android:id="@+id/soundrecorder_textview_recording_hint"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:gravity="center"
         android:paddingTop="30dip"
         android:text="@string/soundrecorder_recording"
         android:textColor="#000000"
-        android:textSize="25dip"
+        android:textSize="25sp"
         android:visibility="invisible" />
 
     <LinearLayout
-        android:id="@+id/recordLayout"
+        android:id="@+id/soundrecorder_linearlayout_record"
         android:layout_width="fill_parent"
         android:layout_height="wrap_content"
         android:layout_gravity="center_horizontal"
@@ -71,7 +71,7 @@
         android:shadowRadius="4" >
 
         <TextView
-            android:id="@+id/recordText"
+            android:id="@+id/soundrecorder_textview_record_start_stop"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:layout_gravity="center_vertical"
@@ -80,14 +80,4 @@
             android:textStyle="bold" />
     </LinearLayout>
 
-    <!--
-         <Button
-        android:id="@+id/buttonRecord"
-        android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
-        android:layout_gravity="center"
-        android:drawableLeft="@drawable/ic_record_inactive_button"
-        android:text="@string/soundrecorder_record_start" />
-    -->
-
 </LinearLayout>

catroid/src/org/catrobat/catroid/soundrecorder/SoundRecorderActivity.java

@@ -59,10 +59,10 @@ public void onCreate(Bundle savedInstanceState) {
 
 		setContentView(R.layout.activity_soundrecorder);
 
-		recordLayout = (LinearLayout) findViewById(R.id.recordLayout);
-		recordButton = (ImageView) findViewById(R.id.recordButton);
-		recordText = (TextView) findViewById(R.id.recordText);
-		recordingIndicationText = (TextView) findViewById(R.id.recording);
+		recordLayout = (LinearLayout) findViewById(R.id.soundrecorder_linearlayout_record);
+		recordButton = (ImageView) findViewById(R.id.soundrecorder_imageview_record);
+		recordText = (TextView) findViewById(R.id.soundrecorder_textview_record_start_stop);
+		recordingIndicationText = (TextView) findViewById(R.id.soundrecorder_textview_recording_hint);
 
 		recordLayout.setOnClickListener(this);
 		Utils.checkForExternalStorageAvailableAndDisplayErrorIfNot(this);
@@ -75,7 +75,7 @@ public void onCreate(Bundle savedInstanceState) {
 	protected void onDestroy() {
 		super.onDestroy();
 
-		unbindDrawables(findViewById(R.id.SoundrecorderActivityRoot));
+		unbindDrawables(findViewById(R.id.soundrecorder));
 		System.gc();
 	}
 
@@ -93,7 +93,7 @@ private void unbindDrawables(View view) {
 
 	@Override
 	public void onClick(View v) {
-		if (v.getId() == R.id.recordLayout) {
+		if (v.getId() == R.id.soundrecorder_linearlayout_record) {
 			if (soundRecorder != null && soundRecorder.isRecording()) {
 				stopRecording();
 				finish();