Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect labeling of summary details #56

Open
markgllin opened this issue Aug 24, 2020 · 0 comments
Open

Incorrect labeling of summary details #56

markgllin opened this issue Aug 24, 2020 · 0 comments

Comments

@markgllin
Copy link

While reviewing my results for some binaries with Asm2Vec, I noticed the % of clones found did not correspond to # of matched functions/# of total functions. e.g.:

Screen Shot 2020-08-24 at 12 48 08 PM

in the picture above, the summary displays 80% for the ratio of matched clones to valid functions. However, we actually get 89% (179/201) using the same values according to the tooltip. The 80% is actually being derived from # of matched functions/source binary's function size (179/221).

From debugging, it appears 179 does correspond to # of matched functions but I'm uncertain what 201 and 221 corresponds to (total valid queries vs. source binary's function size).

May I get some clarity on this?

On top of that, would it be possible to add to the tooltip what "Total Valid Queries" and "Source Binary's Function Size" means? I'm assuming "Total Valid Queries" is the set of valid functions extracted from the source binary and "Source Binary's Function Size" is the sum of sizes of all those functions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant