kubernetes_test.go

// Licensed to Michael Tougeron <github@e.tougeron.com> under
// one or more contributor license agreements. See the LICENSE
// file distributed with this work for additional information
// regarding copyright ownership.
// Michael Tougeron <github@e.tougeron.com> licenses this file
// to you under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//     http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied.  See the License for the
// specific language governing permissions and limitations
// under the License.

package main

import (
	"reflect"
	"testing"

	corev1 "k8s.io/api/core/v1"
	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
	"k8s.io/client-go/kubernetes/fake"
)

var dummyStorageClassName string = "fakeName"

func Test_parseAWSEBSVolumeID(t *testing.T) {
	tests := []struct {
		name        string
		k8sVolumeID string
		want        string
	}{
		{
			name:        "full AWSElasticBlockStore.VolumeID",
			k8sVolumeID: "aws://us-east-1d/vol-089747b9fac6ab469",
			want:        "vol-089747b9fac6ab469",
		},
		{
			name:        "full AWSElasticBlockStore.VolumeID without AZ",
			k8sVolumeID: "aws:///vol-089747b9fac6ab469",
			want:        "vol-089747b9fac6ab469",
		},
		{
			name:        "invalid region but valid VolumeID",
			k8sVolumeID: "aws://something-else/vol-089747b9fac6ab469",
			want:        "vol-089747b9fac6ab469",
		},
		{
			name:        "just the AWSElasticBlockStore.VolumeID",
			k8sVolumeID: "vol-abc123",
			want:        "vol-abc123",
		},
		{
			name:        "invalid AWSElasticBlockStore.VolumeID",
			k8sVolumeID: "aws://089747b9fac6ab469",
			want:        "",
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			if got := parseAWSEBSVolumeID(tt.k8sVolumeID); got != tt.want {
				t.Errorf("parseAWSEBSVolumeID() = %v, want %v", got, tt.want)
			}
		})
	}
}

func Test_parseAWSEFSVolumeID(t *testing.T) {
	tests := []struct {
		name        string
		k8sVolumeID string
		want        string
	}{
		{
			name:        "full AWS-EFS.VolumeID",
			k8sVolumeID: "fs-05b82f747004ac501::fsap-06cc098e562d24942",
			want:        "fsap-06cc098e562d24942",
		},
		{
			name:        "invalid AWS-EFS.VolumeID",
			k8sVolumeID: "fsp-05b82f747004ac501::fsap-06cc098e562d24942",
			want:        "",
		},
		{
			name:        "partial AWS-EFS.VolumeID",
			k8sVolumeID: "fsap-06cc098e562d24942",
			want:        "",
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			if got := parseAWSEFSVolumeID(tt.k8sVolumeID); got != tt.want {
				t.Errorf("parseAWSEFSVolumeID() = %v, want %v", got, tt.want)
			}
		})
	}
}

func Test_isValidTagName(t *testing.T) {
	tests := []struct {
		name string
		key  string
		want bool
	}{
		{
			name: "invalid prefix",
			key:  "kubernetes.io/something",
			want: false,
		},
		{
			name: "valid prefix",
			key:  "my-name.io/something",
			want: true,
		},
		{
			name: "invalid Name",
			key:  "Name",
			want: false,
		},
		{
			name: "invalid KubernetesCluster",
			key:  "KubernetesCluster",
			want: false,
		},
		{
			name: "valid annotation",
			key:  "something",
			want: true,
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			if got := isValidTagName(tt.key); got != tt.want {
				t.Errorf("isValidTagName() = %v, want %v", got, tt.want)
			}
		})
	}
}

func Test_provisionedByAwsEbs(t *testing.T) {

	pvc := &corev1.PersistentVolumeClaim{}
	pvc.SetName("my-pvc")
	pvc.Spec.StorageClassName = &dummyStorageClassName

	tests := []struct {
		name        string
		annotations map[string]string
		want        bool
	}{
		{
			name:        "valid provisioner in-tree aws-ebs legacy annotation",
			annotations: map[string]string{"volume.kubernetes.io/storage-provisioner": "kubernetes.io/aws-ebs"},
			want:        true,
		},
		{
			name:        "valid provisioner ebs.csi.aws.com",
			annotations: map[string]string{"volume.kubernetes.io/storage-provisioner": "ebs.csi.aws.com"},
			want:        true,
		},
		{
			name:        "invalid provisioner",
			annotations: map[string]string{"volume.kubernetes.io/storage-provisioner": "something else"},
			want:        false,
		},
		{
			name:        "valid provisioner in-tree aws-ebs legacy annotation",
			annotations: map[string]string{"volume.beta.kubernetes.io/storage-provisioner": "kubernetes.io/aws-ebs"},
			want:        true,
		},
		{
			name:        "valid provisioner ebs.csi.aws.com legacy annotation",
			annotations: map[string]string{"volume.beta.kubernetes.io/storage-provisioner": "ebs.csi.aws.com"},
			want:        true,
		},
		{
			name:        "invalid provisioner legacy annotation",
			annotations: map[string]string{"volume.beta.kubernetes.io/storage-provisioner": "something else"},
			want:        false,
		},
		{
			name:        "provisioner not set",
			annotations: map[string]string{"some annotation": "something else"},
			want:        false,
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			pvc.SetAnnotations(tt.annotations)
			if got := provisionedByAwsEbs(pvc); got != tt.want {
				t.Errorf("provisionedByAwsEbs() = %v, want %v", got, tt.want)
			}
		})
	}
}

func Test_provisionedByAwsEfs(t *testing.T) {

	pvc := &corev1.PersistentVolumeClaim{}
	pvc.SetName("my-pvc")
	pvc.Spec.StorageClassName = &dummyStorageClassName

	tests := []struct {
		name        string
		annotations map[string]string
		want        bool
	}{
		{
			name:        "valid provisioner efs.csi.aws.com",
			annotations: map[string]string{"volume.kubernetes.io/storage-provisioner": "efs.csi.aws.com"},
			want:        true,
		},
		{
			name:        "invalid provisioner",
			annotations: map[string]string{"volume.kubernetes.io/storage-provisioner": "something else"},
			want:        false,
		},
		{
			name:        "valid provisioner efs.csi.aws.com legacy annotation",
			annotations: map[string]string{"volume.beta.kubernetes.io/storage-provisioner": "efs.csi.aws.com"},
			want:        true,
		},
		{
			name:        "invalid provisioner legacy annotation",
			annotations: map[string]string{"volume.beta.kubernetes.io/storage-provisioner": "something else"},
			want:        false,
		},
		{
			name:        "provisioner not set",
			annotations: map[string]string{"some annotation": "something else"},
			want:        false,
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			pvc.SetAnnotations(tt.annotations)
			if got := provisionedByAwsEfs(pvc); got != tt.want {
				t.Errorf("provisionedByAwsEfs() = %v, want %v", got, tt.want)
			}
		})
	}
}

func Test_buildTags(t *testing.T) {

	pvc := &corev1.PersistentVolumeClaim{}
	pvc.SetName("my-pvc")
	pvc.Spec.StorageClassName = &dummyStorageClassName

	tests := []struct {
		name         string
		defaultTags  map[string]string
		allowAllTags bool
		annotations  map[string]string
		want         map[string]string
		tagFormat    string
	}{
		{
			name:         "ignore annotation set legacy",
			defaultTags:  map[string]string{},
			allowAllTags: false,
			annotations:  map[string]string{"aws-ebs-tagger/ignore": ""},
			want:         map[string]string{},
		},
		{
			name:         "ignore annotation set",
			defaultTags:  map[string]string{},
			allowAllTags: false,
			annotations:  map[string]string{"k8s-pvc-tagger/ignore": ""},
			want:         map[string]string{},
		},
		{
			name:         "ignore annotation set with default tags legacy",
			defaultTags:  map[string]string{"foo": "bar"},
			allowAllTags: false,
			annotations:  map[string]string{"aws-ebs-tagger/ignore": ""},
			want:         map[string]string{},
		},
		{
			name:         "ignore annotation set with default tags",
			defaultTags:  map[string]string{"foo": "bar"},
			allowAllTags: false,
			annotations:  map[string]string{"k8s-pvc-tagger/ignore": ""},
			want:         map[string]string{},
		},
		{
			name:         "ignore annotation set with tags annotation set legacy",
			defaultTags:  map[string]string{},
			allowAllTags: false,
			annotations:  map[string]string{"aws-ebs-tagger/ignore": "exists", "aws-ebs-tagger/tags": "{\"foo\": \"bar\"}"},
			want:         map[string]string{},
		},
		{
			name:         "ignore annotation set with tags annotation set",
			defaultTags:  map[string]string{},
			allowAllTags: false,
			annotations:  map[string]string{"k8s-pvc-tagger/ignore": "exists", "k8s-pvc-tagger/tags": "{\"foo\": \"bar\"}"},
			want:         map[string]string{},
		},
		{
			name:         "tags annotation not set with default tags",
			defaultTags:  map[string]string{"foo": "bar", "something": "else"},
			allowAllTags: false,
			annotations:  map[string]string{},
			want:         map[string]string{"foo": "bar", "something": "else"},
		},
		{
			name:         "tags annotation not set with no default tags",
			defaultTags:  map[string]string{},
			allowAllTags: false,
			annotations:  map[string]string{},
			want:         map[string]string{},
		},
		{
			name:         "tags annotation set empty with no default tags legacy",
			defaultTags:  map[string]string{},
			allowAllTags: false,
			annotations:  map[string]string{"aws-ebs-tagger/tags": ""},
			want:         map[string]string{},
		},
		{
			name:         "tags annotation set empty with no default tags",
			defaultTags:  map[string]string{},
			allowAllTags: false,
			annotations:  map[string]string{"k8s-pvc-tagger/tags": ""},
			want:         map[string]string{},
		},
		{
			name:         "tags annotation set with no default tags legacy",
			defaultTags:  map[string]string{},
			allowAllTags: false,
			annotations:  map[string]string{"aws-ebs-tagger/tags": "{\"foo\": \"bar\"}"},
			want:         map[string]string{"foo": "bar"},
		},
		{
			name:         "tags annotation set with no default tags",
			defaultTags:  map[string]string{},
			allowAllTags: false,
			annotations:  map[string]string{"k8s-pvc-tagger/tags": "{\"foo\": \"bar\"}"},
			want:         map[string]string{"foo": "bar"},
		},
		{
			name:         "tags annotation set with default tags legacy",
			defaultTags:  map[string]string{"foo": "bar"},
			allowAllTags: false,
			annotations:  map[string]string{"aws-ebs-tagger/tags": "{\"something\": \"else\"}"},
			want:         map[string]string{"foo": "bar", "something": "else"},
		},
		{
			name:         "tags annotation set with default tags",
			defaultTags:  map[string]string{"foo": "bar"},
			allowAllTags: false,
			annotations:  map[string]string{"k8s-pvc-tagger/tags": "{\"something\": \"else\"}"},
			want:         map[string]string{"foo": "bar", "something": "else"},
		},
		{
			name:         "tags annotation set with default tags with override legacy",
			defaultTags:  map[string]string{"foo": "foo"},
			allowAllTags: false,
			annotations:  map[string]string{"aws-ebs-tagger/tags": "{\"foo\": \"bar\", \"something\": \"else\"}"},
			want:         map[string]string{"foo": "bar", "something": "else"},
		},
		{
			name:         "tags annotation set with default tags with override",
			defaultTags:  map[string]string{"foo": "foo"},
			allowAllTags: false,
			annotations:  map[string]string{"k8s-pvc-tagger/tags": "{\"foo\": \"bar\", \"something\": \"else\"}"},
			want:         map[string]string{"foo": "bar", "something": "else"},
		},
		{
			name:         "tags annotation invalid json with no default tags legacy",
			defaultTags:  map[string]string{},
			allowAllTags: false,
			annotations:  map[string]string{"aws-ebs-tagger/tags": "'asdas:\"asdasd\""},
			want:         map[string]string{},
		},
		{
			name:         "tags annotation invalid json with no default tags",
			defaultTags:  map[string]string{},
			allowAllTags: false,
			annotations:  map[string]string{"k8s-pvc-tagger/tags": "'asdas:\"asdasd\""},
			want:         map[string]string{},
		},
		{
			name:         "tags annotation invalid json with default tags legacy",
			defaultTags:  map[string]string{"foo": "bar"},
			allowAllTags: false,
			annotations:  map[string]string{"aws-ebs-tagger/tags": "'asdas:\"asdasd\""},
			want:         map[string]string{"foo": "bar"},
		},
		{
			name:         "tags annotation invalid json with default tags",
			defaultTags:  map[string]string{"foo": "bar"},
			allowAllTags: false,
			annotations:  map[string]string{"k8s-pvc-tagger/tags": "'asdas:\"asdasd\""},
			want:         map[string]string{"foo": "bar"},
		},
		{
			name:         "tags annotation set with invalid name with no default tags legacy",
			defaultTags:  map[string]string{},
			allowAllTags: false,
			annotations:  map[string]string{"aws-ebs-tagger/tags": "{\"foo\": \"bar\", \"kubernetes.io/foo\": \"bar\"}"},
			want:         map[string]string{"foo": "bar"},
		},
		{
			name:         "tags annotation set with invalid name with no default tags",
			defaultTags:  map[string]string{},
			allowAllTags: false,
			annotations:  map[string]string{"k8s-pvc-tagger/tags": "{\"foo\": \"bar\", \"kubernetes.io/foo\": \"bar\"}"},
			want:         map[string]string{"foo": "bar"},
		},
		{
			name:         "tags annotation set with invalid name but allowAllTags with no default tags legacy",
			defaultTags:  map[string]string{},
			allowAllTags: true,
			annotations:  map[string]string{"aws-ebs-tagger/tags": "{\"foo\": \"bar\", \"kubernetes.io/foo\": \"bar\"}"},
			want:         map[string]string{"foo": "bar", "kubernetes.io/foo": "bar"},
		},
		{
			name:         "tags annotation set with invalid name but allowAllTags with no default tags",
			defaultTags:  map[string]string{},
			allowAllTags: true,
			annotations:  map[string]string{"k8s-pvc-tagger/tags": "{\"foo\": \"bar\", \"kubernetes.io/foo\": \"bar\"}"},
			want:         map[string]string{"foo": "bar", "kubernetes.io/foo": "bar"},
		},
		{
			name:         "tags annotation set with invalid name but allowAllTags with no default tags",
			defaultTags:  map[string]string{},
			allowAllTags: true,
			annotations:  map[string]string{"k8s-pvc-tagger/tags": "{\"foo\": \"bar\", \"Name\": \"bar\"}"},
			want:         map[string]string{"foo": "bar", "Name": "bar"},
		},
		{
			name:         "tags annotation set with invalid name but allowAllTags with no default tags legacy",
			defaultTags:  map[string]string{},
			allowAllTags: true,
			annotations:  map[string]string{"aws-ebs-tagger/tags": "{\"foo\": \"bar\", \"Name\": \"bar\"}"},
			want:         map[string]string{"foo": "bar", "Name": "bar"},
		},
		{
			name:         "tags annotation set with invalid default tags",
			defaultTags:  map[string]string{"kubernetes.io/foo": "bar"},
			allowAllTags: false,
			annotations:  map[string]string{"k8s-pvc-tagger/tags": "{\"something\": \"else\"}"},
			want:         map[string]string{"something": "else"},
		},
		{
			name:         "tags annotation not set with default tags - csv",
			defaultTags:  map[string]string{"foo": "bar", "something": "else"},
			allowAllTags: false,
			annotations:  map[string]string{},
			want:         map[string]string{"foo": "bar", "something": "else"},
			tagFormat:    "csv",
		},
		{
			name:         "tags annotation not set with no default tags - csv",
			defaultTags:  map[string]string{},
			allowAllTags: false,
			annotations:  map[string]string{},
			want:         map[string]string{},
			tagFormat:    "csv",
		},
		{
			name:         "tags annotation set with default tags - csv legacy",
			defaultTags:  map[string]string{"foo": "bar"},
			allowAllTags: false,
			annotations:  map[string]string{"aws-ebs-tagger/tags": "something=else"},
			want:         map[string]string{"foo": "bar", "something": "else"},
			tagFormat:    "csv",
		},
		{
			name:         "tags annotation set with default tags - csv",
			defaultTags:  map[string]string{"foo": "bar"},
			allowAllTags: false,
			annotations:  map[string]string{"k8s-pvc-tagger/tags": "something=else"},
			want:         map[string]string{"foo": "bar", "something": "else"},
			tagFormat:    "csv",
		},
		{
			name:         "tags annotation set with default tags with override - csv",
			defaultTags:  map[string]string{"foo": "foo"},
			allowAllTags: false,
			annotations:  map[string]string{"k8s-pvc-tagger/tags": "foo=bar,something=else"},
			want:         map[string]string{"foo": "bar", "something": "else"},
			tagFormat:    "csv",
		},
		{
			name:         "tags annotation set with default tags with override - csv legacy",
			defaultTags:  map[string]string{"foo": "foo"},
			allowAllTags: false,
			annotations:  map[string]string{"aws-ebs-tagger/tags": "foo=bar,something=else"},
			want:         map[string]string{"foo": "bar", "something": "else"},
			tagFormat:    "csv",
		},
		{
			name:         "tags annotation set with invalid tags - csv",
			defaultTags:  map[string]string{},
			allowAllTags: false,
			annotations:  map[string]string{"k8s-pvc-tagger/tags": "{\"foo\": \"bar\"}"},
			want:         map[string]string{},
			tagFormat:    "csv",
		},
		{
			name:         "tags annotation set with legacy tag also annotation set",
			defaultTags:  map[string]string{},
			allowAllTags: false,
			annotations:  map[string]string{"k8s-pvc-tagger/tags": "{\"foo\": \"selected\"}", "aws-ebs-tagger/tags": "{\"foo\": \"notselected\"}"},
			want:         map[string]string{"foo": "selected"},
		},
		{
			name:         "tags annotation set but legacy ignore annotation set",
			defaultTags:  map[string]string{},
			allowAllTags: false,
			annotations:  map[string]string{"k8s-pvc-tagger/tags": "{\"foo\": \"selected\"}", "aws-ebs-tagger/ignore": ""},
			want:         map[string]string{},
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			pvc.SetAnnotations(tt.annotations)
			defaultTags = tt.defaultTags
			allowAllTags = tt.allowAllTags
			if tt.tagFormat != "" {
				tagFormat = tt.tagFormat
			} else {
				tagFormat = "json"
			}
			if got := buildTags(pvc); !reflect.DeepEqual(got, tt.want) {
				t.Errorf("buildTags() = %v, want %v", got, tt.want)
			}
			tagFormat = "json"
			defaultTags = map[string]string{}
		})
	}
}

func Test_annotationPrefix(t *testing.T) {

	pvc := &corev1.PersistentVolumeClaim{}
	pvc.SetName("my-pvc")
	defaultAnnotationPrefix := annotationPrefix
	pvc.Spec.StorageClassName = &dummyStorageClassName

	tests := []struct {
		name             string
		annotationPrefix string
		defaultTags      map[string]string
		annotations      map[string]string
		want             map[string]string
	}{
		{
			name:             "annotationPrefix with proper ignore",
			annotationPrefix: "something-else",
			defaultTags:      map[string]string{"foo": "bar"},
			annotations:      map[string]string{"something-else/ignore": ""},
			want:             map[string]string{},
		},
		{
			name:             "annotationPrefix with different ignore legacy",
			annotationPrefix: "something-else",
			defaultTags:      map[string]string{"foo": "bar"},
			annotations:      map[string]string{"aws-ebs-tagger/ignore": ""},
			want:             map[string]string{"foo": "bar"},
		},
		{
			name:             "annotationPrefix with different ignore",
			annotationPrefix: "something-else",
			defaultTags:      map[string]string{"foo": "bar"},
			annotations:      map[string]string{"k8s-pvc-tagger/ignore": ""},
			want:             map[string]string{"foo": "bar"},
		},
		{
			name:             "annotationPrefix with default and custom tags",
			annotationPrefix: "something-else",
			defaultTags:      map[string]string{"foo": "bar"},
			annotations:      map[string]string{"something-else/tags": "{\"something\": \"else\"}"},
			want:             map[string]string{"foo": "bar", "something": "else"},
		},
		{
			name:             "annotationPrefix with default and different custom tags legacy",
			annotationPrefix: "something-else",
			defaultTags:      map[string]string{"foo": "bar"},
			annotations:      map[string]string{"aws-ebs-tagger/tags": "{\"something\": \"else\"}"},
			want:             map[string]string{"foo": "bar"},
		},
		{
			name:             "annotationPrefix with default and different custom tags",
			annotationPrefix: "something-else",
			defaultTags:      map[string]string{"foo": "bar"},
			annotations:      map[string]string{"k8s-pvc-tagger/tags": "{\"something\": \"else\"}"},
			want:             map[string]string{"foo": "bar"},
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			pvc.SetAnnotations(tt.annotations)
			annotationPrefix = tt.annotationPrefix
			defaultTags = tt.defaultTags
			if got := buildTags(pvc); !reflect.DeepEqual(got, tt.want) {
				t.Errorf("buildTags() = %v, want %v", got, tt.want)
			}
			annotationPrefix = defaultAnnotationPrefix
			defaultTags = map[string]string{}
		})
	}
}

func Test_processEBSPersistentVolumeClaim(t *testing.T) {
	volumeName := "pvc-1234"
	pvc := &corev1.PersistentVolumeClaim{}
	pvc.SetName("my-pvc")
	pvc.Spec.VolumeName = volumeName

	tests := []struct {
		name           string
		provisionedBy  string
		tagsAnnotation string
		volumeID       string
		volumeName     string
		wantedTags     map[string]string
		wantedVolumeID string
		wantedErr      bool
	}{
		{
			name:           "csi with valid tags and volume id",
			provisionedBy:  "ebs.csi.aws.com",
			tagsAnnotation: "{\"foo\": \"bar\"}",
			volumeName:     volumeName,
			wantedTags:     map[string]string{"foo": "bar"},
			wantedVolumeID: "vol-12345",
			wantedErr:      false,
		},
		{
			name:           "in-tree with valid tags and volume id",
			provisionedBy:  "kubernetes.io/aws-ebs",
			tagsAnnotation: "{\"foo\": \"bar\"}",
			volumeName:     volumeName,
			volumeID:       "aws://us-east-1a/vol-12345",
			wantedTags:     map[string]string{"foo": "bar"},
			wantedVolumeID: "vol-12345",
			wantedErr:      false,
		},
		{
			name:           "in-tree with valid tags and invalid volume id",
			provisionedBy:  "kubernetes.io/aws-ebs",
			tagsAnnotation: "{\"foo\": \"bar\"}",
			volumeName:     volumeName,
			volumeID:       "aws://us-east-1a/abc123",
			wantedTags:     nil,
			wantedVolumeID: "",
			wantedErr:      true,
		},
		{
			name:           "other with valid tags and volume id",
			provisionedBy:  "foo",
			tagsAnnotation: "{\"foo\": \"bar\"}",
			volumeName:     volumeName,
			wantedTags:     nil,
			wantedVolumeID: "",
			wantedErr:      true,
		},
		{
			name:           "in-tree with missing PV",
			provisionedBy:  "kubernetes.io/aws-ebs",
			tagsAnnotation: "{\"foo\": \"bar\"}",
			volumeName:     "asdf",
			volumeID:       "aws://us-east-1a/vol-12345",
			wantedTags:     nil,
			wantedVolumeID: "",
			wantedErr:      true,
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			pvc.SetAnnotations(map[string]string{
				annotationPrefix + "/tags":                 tt.tagsAnnotation,
				"volume.kubernetes.io/storage-provisioner": tt.provisionedBy,
			})

			var pvSpec corev1.PersistentVolumeSpec
			if tt.provisionedBy == "ebs.csi.aws.com" {
				pvSpec = corev1.PersistentVolumeSpec{
					StorageClassName: dummyStorageClassName,
					PersistentVolumeSource: corev1.PersistentVolumeSource{
						CSI: &corev1.CSIPersistentVolumeSource{
							VolumeHandle: tt.wantedVolumeID,
						},
					},
				}
			} else {
				pvSpec = corev1.PersistentVolumeSpec{
					StorageClassName: dummyStorageClassName,
					PersistentVolumeSource: corev1.PersistentVolumeSource{
						AWSElasticBlockStore: &corev1.AWSElasticBlockStoreVolumeSource{
							VolumeID: tt.volumeID,
						},
					},
				}
			}
			pv := &corev1.PersistentVolume{
				ObjectMeta: metav1.ObjectMeta{
					Name:        tt.volumeName,
					Annotations: map[string]string{},
				},
				Spec: pvSpec,
			}
			k8sClient = fake.NewSimpleClientset(pv)
			volumeID, tags, err := processPersistentVolumeClaim(pvc)
			if (err == nil) == tt.wantedErr {
				t.Errorf("processPersistentVolumeClaim() err = %v, wantedErr %v", err, tt.wantedErr)
			}
			if volumeID != tt.wantedVolumeID {
				t.Errorf("processPersistentVolumeClaim() volumeID = %v, want %v", volumeID, tt.wantedVolumeID)
			}
			if !reflect.DeepEqual(tags, tt.wantedTags) {
				t.Errorf("processPersistentVolumeClaim() tags = %v, want %v", tags, tt.wantedTags)
			}
		})
	}

}

func Test_processEFSPersistentVolumeClaim(t *testing.T) {
	volumeName := "pvc-1234"
	pvc := &corev1.PersistentVolumeClaim{}
	pvc.SetName("my-pvc")
	pvc.Spec.VolumeName = volumeName

	tests := []struct {
		name           string
		provisionedBy  string
		tagsAnnotation string
		volumeID       string
		volumeName     string
		wantedTags     map[string]string
		wantedVolumeID string
		wantedErr      bool
	}{
		{
			name:           "csi with valid tags and volume id",
			provisionedBy:  "efs.csi.aws.com",
			tagsAnnotation: "{\"foo\": \"bar\"}",
			volumeName:     volumeName,
			volumeID:       "fs-05b82f74723423::fsap-06cc098e562d23425",
			wantedTags:     map[string]string{"foo": "bar"},
			wantedVolumeID: "fsap-06cc098e562d23425",
			wantedErr:      false,
		},
		{
			name:           "csi with valid tags and invalid volume id",
			provisionedBy:  "efs.csi.aws.com",
			tagsAnnotation: "{\"foo\": \"bar\"}",
			volumeName:     volumeName,
			volumeID:       "asdf://us-east-1a/vol-12345",
			wantedTags:     nil,
			wantedVolumeID: "",
			wantedErr:      true,
		},
		{
			name:           "other with valid tags and volume id",
			provisionedBy:  "foo",
			tagsAnnotation: "{\"foo\": \"bar\"}",
			volumeName:     volumeName,
			wantedTags:     nil,
			wantedVolumeID: "",
			wantedErr:      true,
		},
		{
			name:           "csi with missing PV",
			provisionedBy:  "efs.csi.aws.com",
			tagsAnnotation: "{\"foo\": \"bar\"}",
			volumeName:     "asdf",
			volumeID:       "fs-05b82f74723423::fsap-06cc098e562d23425",
			wantedTags:     nil,
			wantedVolumeID: "",
			wantedErr:      true,
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			pvc.SetAnnotations(map[string]string{
				annotationPrefix + "/tags":                 tt.tagsAnnotation,
				"volume.kubernetes.io/storage-provisioner": tt.provisionedBy,
			})

			var pvSpec corev1.PersistentVolumeSpec
			if tt.provisionedBy == "efs.csi.aws.com" {
				pvSpec = corev1.PersistentVolumeSpec{
					PersistentVolumeSource: corev1.PersistentVolumeSource{
						CSI: &corev1.CSIPersistentVolumeSource{
							VolumeHandle: tt.volumeID,
						},
					},
				}
			}
			pv := &corev1.PersistentVolume{
				ObjectMeta: metav1.ObjectMeta{
					Name:        tt.volumeName,
					Annotations: map[string]string{},
				},
				Spec: pvSpec,
			}
			k8sClient = fake.NewSimpleClientset(pv)
			volumeID, tags, err := processPersistentVolumeClaim(pvc)
			if (err == nil) == tt.wantedErr {
				t.Errorf("processPersistentVolumeClaim() err = %v, wantedErr %v", err, tt.wantedErr)
			}
			if volumeID != tt.wantedVolumeID {
				t.Errorf("processPersistentVolumeClaim() volumeID = %v, want %v", volumeID, tt.wantedVolumeID)
			}
			if !reflect.DeepEqual(tags, tt.wantedTags) {
				t.Errorf("processPersistentVolumeClaim() tags = %v, want %v", tags, tt.wantedTags)
			}
		})
	}

}

func Test_templatedTags(t *testing.T) {

	pvc := &corev1.PersistentVolumeClaim{}
	pvc.SetName("my-pvc")
	pvc.SetNamespace("my-namespace")
	pvc.Spec.StorageClassName = &dummyStorageClassName

	tests := []struct {
		name        string
		defaultTags map[string]string
		annotations map[string]string
		labels      map[string]string
		want        map[string]string
	}{
		{
			name:        "default tag with template",
			defaultTags: map[string]string{"foo": "{{ .Name }}-{{ .Namespace }}"},
			annotations: map[string]string{},
			labels:      map[string]string{},
			want:        map[string]string{"foo": "my-pvc-my-namespace"},
		},
		{
			name:        "default tag overwritten with tag template",
			defaultTags: map[string]string{"foo": "bar"},
			annotations: map[string]string{annotationPrefix + "/tags": "{\"foo\": \"{{ .Name }}-{{ .Namespace }}\"}"},
			labels:      map[string]string{},
			want:        map[string]string{"foo": "my-pvc-my-namespace"},
		},
		{
			name:        "template using annotation",
			defaultTags: map[string]string{},
			annotations: map[string]string{annotationPrefix + "/tags": "{\"foo\": \"{{ .Name }}-{{ .Annotations.TeamID }}\"}", "TeamID": "1234"},
			labels:      map[string]string{},
			want:        map[string]string{"foo": "my-pvc-1234"},
		},
		{
			name:        "template using label",
			defaultTags: map[string]string{},
			annotations: map[string]string{annotationPrefix + "/tags": "{\"foo\": \"{{ .Name }}-{{ .Labels.TeamID }}\"}"},
			labels:      map[string]string{"TeamID": "1234"},
			want:        map[string]string{"foo": "my-pvc-1234"},
		},
		{
			name:        "template using label and annotation",
			defaultTags: map[string]string{},
			annotations: map[string]string{annotationPrefix + "/tags": "{\"foo\": \"{{ .Name }}-{{ .Labels.TeamID }}\",\"bar\": \"{{ .Name }}-{{ .Annotations.DeptID }}\"}", "DeptID": "ABC"},
			labels:      map[string]string{"TeamID": "1234"},
			want:        map[string]string{"foo": "my-pvc-1234", "bar": "my-pvc-ABC"},
		},
		{
			name:        "template using invalid label",
			defaultTags: map[string]string{},
			annotations: map[string]string{annotationPrefix + "/tags": "{\"foo\": \"{{ .Name }}-{{ .Labels.SomeLabel }}\"}"},
			labels:      map[string]string{"TeamID": "1234"},
			want:        map[string]string{"foo": "my-pvc-"},
		},
		{
			name:        "template using invalid field",
			defaultTags: map[string]string{},
			annotations: map[string]string{annotationPrefix + "/tags": "{\"foo\": \"{{ .Blah }}-{{ .Labels.TeamID }}\"}"},
			labels:      map[string]string{"TeamID": "1234"},
			want:        map[string]string{"foo": "{{ .Blah }}-{{ .Labels.TeamID }}"},
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			pvc.SetAnnotations(tt.annotations)
			pvc.SetLabels(tt.labels)
			defaultTags = tt.defaultTags
			if got := buildTags(pvc); !reflect.DeepEqual(got, tt.want) {
				t.Errorf("buildTags() = %v, want %v", got, tt.want)
			}
			defaultTags = map[string]string{}
		})
	}
}