New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite location_params in PersonWithRemoteFields #96

Open

turino opened this issue Apr 12, 2016 · 1 comment

Assignees

Contributor

turino commented Apr 12, 2016

not sure location.as_json is safe to use here:

def location_params
  if (location.changed & Location::ADDRESS_FIELDS.map(&:to_s)).any?
    location.as_json  # maybe dangerous to reuse serializable_hash here?
  else
     {}
  end
end

need to at least have a test the ensures that changes to Location#serializable_hash don't break this method

The text was updated successfully, but these errors were encountered:

turino self-assigned this

Contributor Author

turino commented Apr 13, 2016

This issue can be closed after this is merged: #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment