Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates and tweaks for debugging. #2

Open
3 tasks done
jmervine opened this issue Feb 16, 2014 · 4 comments
Open
3 tasks done

Updates and tweaks for debugging. #2

jmervine opened this issue Feb 16, 2014 · 4 comments

Comments

@jmervine
Copy link

Requests from @dlitvakb

  • Add back @secure_connection for dev support and rws testing.
  • Add back :debug_json and :debug_request for dev support and rws testing.
  • Add custom header support and set default Content-Type header to application/x-www-form-urlencoded. Note on this; custom content-type didn't work before my changes, it could be passed to the MaxCDN (was NetDNARWS) module, but didn't actually get passed down to the underlying OAuth agent. The primary functional change I made was to make custom content-type support work, and then set it to application/json, which seems to be required for POST and PUT requests with body messages.
@jmervine
Copy link
Author

While implementing these, I left the default content-type as application/json as body based POST and PUT requests fail with application/x-www-form-urlencoded.

jmervine pushed a commit that referenced this issue Feb 16, 2014
@jmervine
Copy link
Author

Released with version 0.1.3.

@jmervine
Copy link
Author

Interesting point, I can sucessfully POST and PUT from the Node.js client with Content-Type: application/x-www-form-urlencoded.

@jdorfman @dlitvakb Let me know if you want me to do some research in to getting this working with x-www-form-urlencoded. Otherwise, close this again.

@jmervine jmervine reopened this Feb 17, 2014
@dlitvakb
Copy link

@jmervine Python and PHP libraries also use application/x-www-form-urlencoded dont know why it is not working for you, as it has always been working for me even in this library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants