From ada0d1ab8e8efeadf37f540f0635193b53f01a30 Mon Sep 17 00:00:00 2001 From: Josh Mervine Date: Wed, 26 Feb 2014 23:57:14 -0800 Subject: [PATCH] Fixing a bug with calling delete on a single file as a string. --- CHANGELOG.md | 1 + README.md | 5 ----- index.js | 2 +- test/index_test.js | 18 ++++++++++++++++++ 4 files changed, 20 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5993b95..51ec407 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ ### v0.1.4 - Adding alias for `maxcdn.del`. +- Fixing a bug with calling delete on a single file as string. ### v0.1.3 diff --git a/README.md b/README.md index 90519c4..38328c0 100644 --- a/README.md +++ b/README.md @@ -94,11 +94,6 @@ maxcdn.del('zones/pull.json/'+zoneId+'/cache', files, function(err, results) { }); ``` -#### Not Implemented - -* post - fails with error, getting the same error with Ruby gem. - - ## Running Tests #### Unit Tests diff --git a/index.js b/index.js index cfe7e10..741b80c 100644 --- a/index.js +++ b/index.js @@ -96,7 +96,7 @@ function del(url, files, callback) { } if (typeof files === 'string') { - files = "files="+string; + files = "files="+files; } else if (Array.isArray(files)) { files = stringify(files); } else if (files && files.files) { diff --git a/test/index_test.js b/test/index_test.js index 1a918d7..1e5a33a 100644 --- a/test/index_test.js +++ b/test/index_test.js @@ -95,6 +95,15 @@ test('maxcdn', function(t) { t.notOk(data.arguments[3], 'delete sends data'); }); + m.delete('path', 'path1', function(err, data) { + t.error(err, 'delete (via Array) w/o error'); + t.equal(data.foo, 'bar', 'delete (via Array) w/ data'); + t.equal(data.arguments[0], + 'https://rws.netdna.com/alias/path?files=path1', + 'delete (via Array) w/ path'); + t.notOk(data.arguments[3], 'delete (via Array) sends data'); + }); + m.delete('path', ['path1','path2'], function(err, data) { t.error(err, 'delete (via Array) w/o error'); t.equal(data.foo, 'bar', 'delete (via Array) w/ data'); @@ -120,6 +129,15 @@ test('maxcdn', function(t) { t.notOk(data.arguments[3], 'del sends data'); }); + m.del('path', 'path1', function(err, data) { + t.error(err, 'delete (via Array) w/o error'); + t.equal(data.foo, 'bar', 'delete (via Array) w/ data'); + t.equal(data.arguments[0], + 'https://rws.netdna.com/alias/path?files=path1', + 'delete (via Array) w/ path'); + t.notOk(data.arguments[3], 'delete (via Array) sends data'); + }); + m.del('path', ['path1','path2'], function(err, data) { t.error(err, 'del (via Array) w/o error'); t.equal(data.foo, 'bar', 'del (via Array) w/ data');