Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning to functions in cpu.py #17

Open
giulianogiari opened this issue Apr 18, 2023 · 2 comments
Open

add warning to functions in cpu.py #17

giulianogiari opened this issue Apr 18, 2023 · 2 comments
Assignees

Comments

@giulianogiari
Copy link
Collaborator

No description provided.

@giulianogiari giulianogiari self-assigned this Apr 19, 2023
@giulianogiari
Copy link
Collaborator Author

this referes to get_cpu_info and get_cpu_usage.
for the missing tdp data we decided to throw an error rather than a warning. do we want to do the same for the other functions?
i guess that get_cpu_info yes, because the code will anyway throw errors later, whereas for cpu_percentage since it will be called multiple times during we can send a warning to not break the code if it doesnt return the expected output just once?

@FrnRmn
Copy link
Collaborator

FrnRmn commented Oct 17, 2023

Yep, get_cpu_info() should raise a specific error of its own. Currently, if it fails, it will make get_cpu_tdp() fail, without discerning why.

FrnRmn pushed a commit that referenced this issue May 13, 2024
FrnRmn added a commit that referenced this issue May 13, 2024
handle error in finding cpu info #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants