Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: [Firefox] breakpoints not being respected #561

Open
dantecarlo opened this issue Nov 18, 2022 · 6 comments
Open

Bug: [Firefox] breakpoints not being respected #561

dantecarlo opened this issue Nov 18, 2022 · 6 comments

Comments

@dantecarlo
Copy link

when printing in firefox it reduces the size of the iframe, in the case of the 1024 brakepoint, it prints as if it were mobile.
Example code:
https://codesandbox.io/s/lucid-grass-px87eq?file=/src/App.js

print firefox

@dantecarlo
Copy link
Author

dantecarlo commented Nov 18, 2022

@MatthewHerbst if you could add an optional prop to give a fixed size to the iframe it would be excellent and would help a lot.

@MatthewHerbst
Copy link
Owner

This almost feels like a different issue, since we know from the previous bug fix that the window should be larger now, which means even if I added a prop to set the size manually, I think Firefox would still print mobile. Maybe we have to set a different property of the iframe for Firefox to print the correct size. I will test around with this tonight (and I will add the props)

@MatthewHerbst
Copy link
Owner

So, while I can replicate the issue on FIrefox when using Codesandbox, I can't replicate the issue locally on Firefox. This makes me think the issue is specific to Codesandbox/code running within an iframe. Still not sure why it works fine in Chrome but not Firefox though, they clearly have different rules for some things

@dantecarlo
Copy link
Author

I get this bug running firefox locally in my project and I try to replicate it on firefox on codesandbox.
Steps to follow.
Place a brakepoint in, e.g. 1024px
Place your screen in 1024px exactly
try to print

@MatthewHerbst
Copy link
Owner

Hmm. I can see a breakpoint issue with FF, though not sure how to fix, there aren't other properties besides width/height that I know about for iframes. Will continue to investigate

@MatthewHerbst MatthewHerbst changed the title Bug - when printing in Firefox it reduces the size of the iframe Bug: [Firefox] breakpoints not being respected Nov 22, 2022
@yadavivek3
Copy link

Hi @MatthewHerbst

I also encountered the same issue in firefox and safari. In Chrome it works fine. Any update on this issue ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants