Skip to content

Commit cfd54e2

Browse files
committed
migrate changes from Propagate failures in pandas integration tests rapidsai#17489
1 parent f54c1a5 commit cfd54e2

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

Diff for: ci/cudf_pandas_scripts/third-party-integration/test.sh

+11-5
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ main() {
2626
LIBS=${LIBS#[}
2727
LIBS=${LIBS%]}
2828

29+
ANY_FAILURES=0
30+
2931
for lib in ${LIBS//,/ }; do
3032
lib=$(echo "$lib" | tr -d '""')
3133
echo "Running tests for library $lib"
@@ -56,10 +58,6 @@ main() {
5658
rapids-logger "Check GPU usage"
5759
nvidia-smi
5860

59-
EXITCODE=0
60-
trap "EXITCODE=1" ERR
61-
set +e
62-
6361
rapids-logger "pytest ${lib}"
6462

6563
NUM_PROCESSES=8
@@ -72,12 +70,20 @@ main() {
7270
fi
7371
done
7472

73+
EXITCODE=0
74+
trap "EXITCODE=1" ERR
75+
set +e
76+
7577
TEST_DIR=${TEST_DIR} NUM_PROCESSES=${NUM_PROCESSES} ci/cudf_pandas_scripts/third-party-integration/run-library-tests.sh ${lib}
7678

79+
set -e
7780
rapids-logger "Test script exiting with value: ${EXITCODE}"
81+
if [[ ${EXITCODE} != 0 ]]; then
82+
ANY_FAILURES=1
83+
fi
7884
done
7985

80-
exit ${EXITCODE}
86+
exit ${ANY_FAILURES}
8187
}
8288

8389
main "$@"

Diff for: python/cudf/cudf_pandas_tests/third_party_integration_tests/tests/test_stumpy_distributed.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def test_multidimensional_distributed_timeseries(dask_client):
4141
rng = np.random.default_rng(seed=42)
4242
# Each row represents data from a different dimension while each column represents
4343
# data from the same dimension
44-
your_time_series = rng.random(3, 1000)
44+
your_time_series = rng.random((3, 1000))
4545
# Approximately, how many data points might be found in a pattern
4646
window_size = 50
4747

0 commit comments

Comments
 (0)