Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Data private in EbmlBinary #34

Open
robUx4 opened this issue Feb 12, 2018 · 2 comments
Open

Make Data private in EbmlBinary #34

robUx4 opened this issue Feb 12, 2018 · 2 comments
Labels
abi-break breaks the ABI (e.g. programs linked against the library have to be recompiled) api-break breaks the API (e.g. programs using it will have to adjust their source code) enhancement

Comments

@robUx4
Copy link
Contributor

robUx4 commented Feb 12, 2018

Add protected accessors if needed.

This will make the use of Data/Size safer, allowing asserts to detect mismatches early.
@mbunkus mbunkus added api-break breaks the API (e.g. programs using it will have to adjust their source code) abi-break breaks the ABI (e.g. programs linked against the library have to be recompiled) labels Feb 15, 2018
@mbunkus
Copy link
Contributor

mbunkus commented Feb 15, 2018

Sure, that would be nice.

I've just added two labels, api-change and abi-change. The latter is especially important for release announcements because distros will have to bump the soname of the library. This change is one that would break both the API and the ABI. We should strive to group ABI-breaking changes in a single release.

@mbunkus
Copy link
Contributor

mbunkus commented Feb 15, 2018

Doh, I meant to call them api-break and abi-break, because breaking both is what's problematic. A simple addition to the API isn't. I've renamed the labels accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
abi-break breaks the ABI (e.g. programs linked against the library have to be recompiled) api-break breaks the API (e.g. programs using it will have to adjust their source code) enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbunkus @robUx4