-
Notifications
You must be signed in to change notification settings - Fork 4
Integrate high-level observability using Tracer #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This will be starting off as more of a research effort, then later it might become more of an implementation issue. |
Logger is used in a lot of subpackages and the version needs to be updated everywhere. Instead of updating the version manually, the following needs to be done:
This should match the version of the dependency in the current Without updating this in all the dependencies, Polykey will fail to compile. |
Well due to semantic versioning it should have been a minor update that easily flowed to all dependencies. No need to update everything. |
I think the issue was when we were trying to give the RPC a logger, when the RPC was using the older version and polykey used the newer version. That made the RPC logger instance different than the polykey one. The difference could have been also caused due to different symbols, as even with the same name, two symbols can be technically different in what they represent, which was why it was complaining. After overriding the version, all references to |
Yes you have to beware of this. Keep track of it using npm command that gives you a tree of the dependencies. |
Is this dependent on #391? |
Not really, I can run the program just fine locally, and monkey-patching is local-only as well. I'm working on this right now, actually. |
Refer to MatrixAI/js-logger#52 (comment) - and define a few phases: after you have experimental visualisation, the next step is to apply it to areas where we know there are resource leakage.
|
Specification
Some work has been done in js-logger for rolling out a custom implementation of tracing which supports streaming and potentially unending spans. (js-logger#47). We now need to use the tracing system in Polykey to gain observability during Polykey's runtime.
Obtaining observability helps debug resource leaks more easily, and given how frequently the seednodes shut down and polykey remains stuck in a stopping state, there are a lot of them. This is meant to simplify finding and fixing them.
Additional context
Tasks
The text was updated successfully, but these errors were encountered: