-
Notifications
You must be signed in to change notification settings - Fork 4
Implement secrets cp
command
#249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I want to point out that You have consider these scenarios:
Then imagine that all works also recursively. |
Yeah, it's a complex and I've considered most of that already. I think the most complex part of this is the recursive walking and globing of the file paths. I've already completed a utility for this in MatrixAI/Polykey#767 which works on real fs along with our fs. It supports the whole glob standard using Along with that there's sending the file tree across the network so we can write it between the real FS locally and the node's efs. I'm half way through this now with MatrixAI/Polykey#774. Besides that I still need to work out how I want to structure the RPC commands. If we say, want a specilized RPC for CP, or more generalised RPC for plumbing. I need to do some prototyping to get an idea of the constraints. The plumbing style might require the ability to lock and hold transactions between RPC calls. |
I remember having a discussion about the case where we perform |
Specification
The
secrets cp
command is very similar to thesecrets mv
command. It will copy the provided paths to the provided destination.There are two main differences between the
mv
command.So there are no subtle behaviours with the moving the file vs copying them between filesystems.
Additional context
Related #32
Tasks
secrets cp
commandThe text was updated successfully, but these errors were encountered: