Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests #51

Open
davidwaroquiers opened this issue Nov 29, 2024 · 2 comments
Open

Integration tests #51

davidwaroquiers opened this issue Nov 29, 2024 · 2 comments

Comments

@davidwaroquiers
Copy link
Member

Following the discussion and PR (Matgenix/jobflow-remote#160, now merged) in jobflow-remote for integration tests. It would be good to have integration tests for the different functionalities of the different queue managers.
@ml-evs When you have some time to just set up the same containers that are in jobflow-remote here so that others can contribute to the tests.
Maybe one comment/question: this will be kind of the same containers that are spawned. Is there any way to make sure this continues to be the same ? I guess the easiest is to just copy the files from jfr needed to start and configure slurm and sge containers but if for some reason we have to change something there, we'd need to change in both jfr and qtoolkit. Any solution that you'd see for that ?

@ml-evs
Copy link
Member

ml-evs commented Nov 29, 2024

I would suggest pushing the latest JFR container build to ghcr.io and then only pulling it inside qtoolkit CI, so that the latest commits on develop are available here. Alternatively, the CI or local tests of qtoolkit can simply checkout a certain version of JFR and do the build.

I'm heading to the US tomorrow for MRS so probably won't be able to do this until the new year.

@davidwaroquiers
Copy link
Member Author

I would suggest pushing the latest JFR container build to ghcr.io and then only pulling it inside qtoolkit CI, so that the latest commits on develop are available here. Alternatively, the CI or local tests of qtoolkit can simply checkout a certain version of JFR and do the build.

I'm heading to the US tomorrow for MRS so probably won't be able to do this until the new year.

Thanks! Cleanest option seems ghcr right? Sure, it's not urgent! Have a good trip there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants