You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following the discussion and PR (Matgenix/jobflow-remote#160, now merged) in jobflow-remote for integration tests. It would be good to have integration tests for the different functionalities of the different queue managers. @ml-evs When you have some time to just set up the same containers that are in jobflow-remote here so that others can contribute to the tests.
Maybe one comment/question: this will be kind of the same containers that are spawned. Is there any way to make sure this continues to be the same ? I guess the easiest is to just copy the files from jfr needed to start and configure slurm and sge containers but if for some reason we have to change something there, we'd need to change in both jfr and qtoolkit. Any solution that you'd see for that ?
The text was updated successfully, but these errors were encountered:
I would suggest pushing the latest JFR container build to ghcr.io and then only pulling it inside qtoolkit CI, so that the latest commits on develop are available here. Alternatively, the CI or local tests of qtoolkit can simply checkout a certain version of JFR and do the build.
I'm heading to the US tomorrow for MRS so probably won't be able to do this until the new year.
I would suggest pushing the latest JFR container build to ghcr.io and then only pulling it inside qtoolkit CI, so that the latest commits on develop are available here. Alternatively, the CI or local tests of qtoolkit can simply checkout a certain version of JFR and do the build.
I'm heading to the US tomorrow for MRS so probably won't be able to do this until the new year.
Thanks! Cleanest option seems ghcr right? Sure, it's not urgent! Have a good trip there
Following the discussion and PR (Matgenix/jobflow-remote#160, now merged) in jobflow-remote for integration tests. It would be good to have integration tests for the different functionalities of the different queue managers.
@ml-evs When you have some time to just set up the same containers that are in jobflow-remote here so that others can contribute to the tests.
Maybe one comment/question: this will be kind of the same containers that are spawned. Is there any way to make sure this continues to be the same ? I guess the easiest is to just copy the files from jfr needed to start and configure slurm and sge containers but if for some reason we have to change something there, we'd need to change in both jfr and qtoolkit. Any solution that you'd see for that ?
The text was updated successfully, but these errors were encountered: