Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Version components prefixed with zeros are not considered valid anymore #255

Open
fivaldi opened this issue Dec 31, 2024 · 2 comments

Comments

@fivaldi
Copy link

fivaldi commented Dec 31, 2024

Accto https://helm.sh/docs/chart_template_guide/function_list/#semvercompare , helm uses this (Masterminds/semver) library.

After switching helm from 3.15.3 to 3.16.4, the following issue occurred:
After switching helmfile from 0.169.1 to 0.169.2, the following issue occurred:

E.g. 01.2.3 or 1.02.3 or 1.2.03 are not valid anymore, though they're not against semver. See the regex reference in https://semver.org/ and the linked examples: https://regex101.com/r/Ly7O1x/3/

image

The regression appears after upgrading Masterminds/semver from 3.3.0 to 3.3.1.

@fivaldi fivaldi changed the title [bug] Version components prefixed with zeros are not valid anymore [bug] Version components prefixed with zeros are not considered valid anymore Dec 31, 2024
@yxxhero
Copy link

yxxhero commented Jan 5, 2025

@mattfarina could you take a look? thanks so much.

@stevekuznetsov
Copy link

Seems like this was the commit that introduced the behavior: 252dd61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants