Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support strict comparisons #247

Open
mattfarina opened this issue Aug 27, 2024 · 0 comments
Open

Support strict comparisons #247

mattfarina opened this issue Aug 27, 2024 · 0 comments

Comments

@mattfarina
Copy link
Member

PR #243 suggested the idea of a strict comparison (i.e. ==) that does direct string comparisons. Stricter comparisons are a good idea. This issue captures some notes and requirements (for myself for later).

  1. If there is a == there should be a !== to complement it
  2. There should be a way to do strict comparisons with build metadata taken into account and with it skipped
  3. Consider comparisons to node-semver which does not expose it's == and === functionality in the Comparator but it exists for direct use (and has for over a decade).
  4. If a full semver is NOT provided a loose (dirty) handling should be enabled so that users get what they expect. If it's not loose than a ==1 will NEVER match to anything because a version would be 1.0.0 and a strict string comparison between those would be different.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant