Update Example to v10.0.0

MasterKale · Apr 13, 2024 · b299b51 · b299b51
1 parent 81d9e49
commit b299b51
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 29 deletions.
diff --git a/example/fido-conformance.ts b/example/fido-conformance.ts
@@ -11,7 +11,6 @@ import {
   verifyAuthenticationResponse,
   verifyRegistrationResponse,
 } from '@simplewebauthn/server';
-import { isoBase64URL, isoUint8Array } from '@simplewebauthn/server/helpers';
 import { AuthenticationResponseJSON, RegistrationResponseJSON } from '@simplewebauthn/types';
 
 import { expectedOrigin, rpID } from './index';
@@ -234,6 +233,7 @@ fidoConformanceRouter.post('/assertion/options', async (req, res) => {
   const { devices } = user;
 
   const opts = await generateAuthenticationOptions({
+    rpID,
     extensions,
     userVerification,
     allowCredentials: devices.map((dev) => ({
@@ -269,10 +269,7 @@ fidoConformanceRouter.post('/assertion/result', async (req, res) => {
     return res.status(400).send({ errorMessage: msg });
   }
 
-  const credIDBuffer = isoBase64URL.toBuffer(id);
-  const existingDevice = user.devices.find((device) =>
-    isoUint8Array.areEqual(device.credentialID, credIDBuffer)
-  );
+  const existingDevice = user.devices.find((device) => device.credentialID === id);
 
   if (!existingDevice) {
     const msg = `Could not find device matching ${id}`;

diff --git a/example/index.ts b/example/index.ts
@@ -23,7 +23,6 @@ import {
   verifyAuthenticationResponse,
   verifyRegistrationResponse,
 } from '@simplewebauthn/server';
-import { isoBase64URL, isoUint8Array } from '@simplewebauthn/server/helpers';
 import type {
   GenerateAuthenticationOptionsOpts,
   GenerateRegistrationOptionsOpts,
@@ -126,7 +125,6 @@ app.get('/generate-registration-options', async (req, res) => {
   const opts: GenerateRegistrationOptionsOpts = {
     rpName: 'SimpleWebAuthn Example',
     rpID,
-    userID: loggedInUserId,
     userName: username,
     timeout: 60000,
     attestationType: 'none',
@@ -195,9 +193,7 @@ app.post('/verify-registration', async (req, res) => {
   if (verified && registrationInfo) {
     const { credentialPublicKey, credentialID, counter } = registrationInfo;
 
-    const existingDevice = user.devices.find((device) =>
-      isoUint8Array.areEqual(device.credentialID, credentialID)
-    );
+    const existingDevice = user.devices.find((device) => device.credentialID === credentialID);
 
     if (!existingDevice) {
       /**
@@ -260,10 +256,9 @@ app.post('/verify-authentication', async (req, res) => {
   const expectedChallenge = req.session.currentChallenge;
 
   let dbAuthenticator;
-  const bodyCredIDBuffer = isoBase64URL.toBuffer(body.rawId);
   // "Query the DB" here for an authenticator matching `credentialID`
   for (const dev of user.devices) {
-    if (isoUint8Array.areEqual(dev.credentialID, bodyCredIDBuffer)) {
+    if (dev.credentialID === body.id) {
       dbAuthenticator = dev;
       break;
     }

diff --git a/example/package-lock.json b/example/package-lock.json
diff --git a/example/package.json b/example/package.json
@@ -11,7 +11,7 @@
   "author": "",
   "license": "ISC",
   "dependencies": {
-    "@simplewebauthn/server": "9.0.3",
+    "@simplewebauthn/server": "10.0.0",
     "dotenv": "^10.0.0",
     "express": "^4.17.1",
     "express-session": "^1.17.3",