Optional matplotlib dependency #311
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelstudios
force-pushed
the
task/refactor-matplotlib
branch
from
8e96aff to
3555f72
Compare
axelstudios
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors all
matplotlibimports to be lazily imported with graceful error-handling to separate core functionality from visualization.Pygfunction can now be installed with optional matplotlib support:
pip install pygfunctionpip install pygfunction[plot]Attempting to call a function like
borefield.visualize_field()without theplotextra will result in the error:It also fixes a small handful of typos, and updates the minimum matplotlib version for compatibility with NumPy 2.0.