Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement and register CallHierarchyProvider #96

Open
ghost opened this issue May 11, 2020 · 2 comments
Open

Implement and register CallHierarchyProvider #96

ghost opened this issue May 11, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented May 11, 2020

First, thank you for an awesome extension. I use it regularly and it's miles ahead of its alternatives.

As of VSCode 1.33 there's a proposed API for providing call hierarchies.
Can this extension register as a Call Hierarchy Provider? This would make use of VSCode's UI, and I thought it wouldn't be that hard since this extension already has this functionality.

I apologize for not submitting a PR, I'm not familiar with TypeScript in general, and VSCode extensions in particular.
Resources that may be helpful:

Thanks!

@MaskRay
Copy link
Owner

MaskRay commented Jul 4, 2020

VSCode has its own hierarchy implementation: src/hierarchies/. I have expressed my opinions about VSCode's design but apparently they were not considered...

I have seen textDocument/callHierarchy on https://microsoft.github.io/language-server-protocol/specifications/specification-3-16/ There is no children property and tags?: SymbolTag[]; references a type SymbolTag which is not really defined...

Currently there is insufficient information to implement this stuff, I think...

@MaskRay MaskRay added the enhancement New feature or request label Jul 4, 2020
@ghost
Copy link
Author

ghost commented Jul 5, 2020

Thank you for your response.
I'll look into it if I have the time in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant