Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installable projet? #178

Open
cblegare opened this issue Feb 28, 2025 · 10 comments · May be fixed by #180
Open

Installable projet? #178

cblegare opened this issue Feb 28, 2025 · 10 comments · May be fixed by #180

Comments

@cblegare
Copy link

Hello, thank you for this project!

It would be really nice to be able to install this tool just like other installable command line tools using pip.

Would you be open to do this? Would you be open to this kind of contribution?

@MartinPacker
Copy link
Owner

I would be open to a contribution to do this. But I need it to be easy to push changes to the repo and not difficult to create a release. Today both are very easy to do.

Personally, I'm only have experience with pip as a consumer.

@cblegare
Copy link
Author

cblegare commented Mar 3, 2025

Hi again! Thank you for your message.

I completly understand your concern here.

When I get a minute, I'll create a PR making this possible and we'll see if that suits you

@MartinPacker
Copy link
Owner

Thanks. I actually went through the process of using the PyPi test site to try out the packaging.

My guess is one PyPi release every major release is reasonable, not every minor update. It probably requires me to copy files into another directory and editing the metadata before using builds and twine`.

@cblegare
Copy link
Author

cblegare commented Mar 3, 2025

Yes, and this is what I'm doing in a PR!

I'll setup the declarative configuration using setuptools so you don't have to install and learn a new tool.

I'll also configure "console scripts" and probably refactor some code so that most of top-level code in the md2pptx file in within a function

I suggest we continue the discussion once the PR is available.

@MartinPacker
Copy link
Owner

Is refactoring the md2pptx code necessary?

@cblegare cblegare linked a pull request Mar 4, 2025 that will close this issue
@MartinPacker
Copy link
Owner

I'm traveling at the moment but hope to look at this over the next few days. I see your PR, Charles, so thanks for that.

I also need to fix Issue 179 in the same timeframe - and call it a release.

Please bear with me.

@MartinPacker
Copy link
Owner

I'm afraid you're going to have to rework this once I release v5.4.1 with the fix for Issue 179.

Sorry about this.

@MartinPacker
Copy link
Owner

By the way, how is this supposed to work for people who git clone rather than pip install?

@MartinPacker
Copy link
Owner

Or just plain take the zip file from a release?

@MartinPacker
Copy link
Owner

v5.4.1 is out now. Now to go catch a plane home... :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants