Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cltt, atsfp, tsfp and tstp as date formatted properties #31

Open
jjakob opened this issue Jul 18, 2019 · 2 comments
Open

Add cltt, atsfp, tsfp and tstp as date formatted properties #31

jjakob opened this issue Jul 18, 2019 · 2 comments

Comments

@jjakob
Copy link

jjakob commented Jul 18, 2019

There is a way to get these from data{} but unformatted, as-is in leases file.
start and end get formatted with parse_time so these four should be also. Otherwise we'd need to duplicate the parse_time in our script.

@MartijnBraam
Copy link
Owner

That sounds like a good improvement. I'll look into it

@jjakob
Copy link
Author

jjakob commented Jul 21, 2019

Also worth documenting that the times are in UTC regardless of the system timezone and the datatime objects are naive (have no timezone data). It would maybe be useful to make these aware.

It wouldn't simplify things much as to conversion to local time but might be more correct.

https://github.com/vyos/vyos-1x/blob/9ff4f0c9f7cc75168b116de3a7d7adecbcc3bde1/src/op_mode/show_dhcpv6.py#L71

https://github.com/vyos/vyos-1x/blob/9ff4f0c9f7cc75168b116de3a7d7adecbcc3bde1/src/op_mode/show_dhcpv6.py#L64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants