You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I swapped from PID to MPC temperature control, and suddenly I got a bunch of build errors. Upon investigating, it seems that the filament load/unload code for a DGUS MKS screen has gotten tied to PID temperature control, instead of the original DGUS_FILAMENT_LOADUNLOAD define. The offending commit is ac4fefa, I suspect that when cleaning up the DGUS code, the wrong #if was retained.
Changing line 81 of the DGUSScreenHandler.h file to #if ENABLED(DGUS_FILAMENT_LOADUNLOAD) fixed the build errors for me
Bug Timeline
No response
Expected behavior
No response
Actual behavior
No response
Steps to Reproduce
No response
Version of Marlin Firmware
2.1.2.4
Printer model
No response
Electronics
No response
LCD/Controller
No response
Other add-ons
No response
Bed Leveling
None
Your Slicer
None
Host Software
None
Don't forget to include
A ZIP file containing your Configuration.h and Configuration_adv.h.
Did you test the latest
bugfix-2.1.x
code?Yes, and the problem still exists.
Bug Description
I swapped from PID to MPC temperature control, and suddenly I got a bunch of build errors. Upon investigating, it seems that the filament load/unload code for a DGUS MKS screen has gotten tied to PID temperature control, instead of the original DGUS_FILAMENT_LOADUNLOAD define. The offending commit is ac4fefa, I suspect that when cleaning up the DGUS code, the wrong
#if
was retained.Changing line 81 of the DGUSScreenHandler.h file to
#if ENABLED(DGUS_FILAMENT_LOADUNLOAD)
fixed the build errors for meBug Timeline
No response
Expected behavior
No response
Actual behavior
No response
Steps to Reproduce
No response
Version of Marlin Firmware
2.1.2.4
Printer model
No response
Electronics
No response
LCD/Controller
No response
Other add-ons
No response
Bed Leveling
None
Your Slicer
None
Host Software
None
Don't forget to include
Configuration.h
andConfiguration_adv.h
.Additional information & file uploads
Configuration.zip
The text was updated successfully, but these errors were encountered: