Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Filament load/unload for DGUS_LCD_UI_MKS is tied to HAS_PID_HEATING instead of DGUS_FILAMENT_LOADUNLOAD #27508

Open
1 task done
vehystrix opened this issue Oct 31, 2024 · 0 comments

Comments

@vehystrix
Copy link

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

I swapped from PID to MPC temperature control, and suddenly I got a bunch of build errors. Upon investigating, it seems that the filament load/unload code for a DGUS MKS screen has gotten tied to PID temperature control, instead of the original DGUS_FILAMENT_LOADUNLOAD define. The offending commit is ac4fefa, I suspect that when cleaning up the DGUS code, the wrong #if was retained.

Changing line 81 of the DGUSScreenHandler.h file to #if ENABLED(DGUS_FILAMENT_LOADUNLOAD) fixed the build errors for me

Bug Timeline

No response

Expected behavior

No response

Actual behavior

No response

Steps to Reproduce

No response

Version of Marlin Firmware

2.1.2.4

Printer model

No response

Electronics

No response

LCD/Controller

No response

Other add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

Configuration.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants