Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Sort out FSMC DMA for STM32F1xx #27460

Open
SMH17 opened this issue Oct 7, 2024 · 1 comment
Open

[BUG] Sort out FSMC DMA for STM32F1xx #27460

SMH17 opened this issue Oct 7, 2024 · 1 comment

Comments

@SMH17
Copy link

SMH17 commented Oct 7, 2024

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

I faced issues with DMA of an STM32F1xx based boards and FSMC with latest version of Marlin, after investigating the issue I have seen that this code has been added, this changes the DMA channel used by FSMC(that was correctly set to DMA2_Channel1 before) and it seems intended to fix the analogous issue on GD32Fxx clones, but since GD32xxx clones aren't exactly drop in replacements for STM32F1xxx MCUs and there are design differences, attempting to fix the issue on GD32Fxxx reckless merging code in STM32 HAL without any proper distinction, inevitably causes problems on the regular STM32Fxxx microcontrollers and hard to debug mess to codebase.

I haven't checked if similar approach has been used also for other GD32 MCUs.

@thinkyhead
Copy link
Member

I went ahead and reverted that particular change, which may leave a conflicting DMA in place between FSMC and some other functions. If there is real interest in sorting this out and figuring out a good way to ensure there are never conflicting or shared DMA channels, let's aim for that. The solution was originally suggested in #27385 by @konradmb.

@thinkyhead thinkyhead changed the title [BUG] To fix FSMC in STM32F1xx clones it has been broken in the original STM32F1xx [BUG] Sort out FSMC DMA for STM32F1xx Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants