Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hardcoded database credentials with environment variable #8

Open
Markkaz opened this issue Jul 7, 2021 · 0 comments
Open

Replace hardcoded database credentials with environment variable #8

Markkaz opened this issue Jul 7, 2021 · 0 comments
Assignees
@Markkaz
Labels
Testability Issue

Comments

@Markkaz
Copy link
Owner

Markkaz commented Jul 7, 2021

Currently the database connection details are hardcoded in consts in the PHP code. This makes it hard to test the application in its own environment.
In addition, it is a bad practice to keep secrets in checked-in code.

Recommended to replace it with environment variables. We can use the DotENV library.
@Markkaz Markkaz self-assigned this Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Markkaz Markkaz

Labels
Testability Issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Markkaz