Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy initializing of playwright #3757

Open
Noordsestern opened this issue Aug 22, 2024 · 4 comments
Open

Lazy initializing of playwright #3757

Noordsestern opened this issue Aug 22, 2024 · 4 comments
Labels
enhancement New feature or request priority: high

Comments

@Noordsestern
Copy link
Member

Is your feature request related to a problem? Please describe.
We have test cases that do not use a Browser keyword, however due to reasons, some of the keywords used import a resource file with Browser library. Thus Browser library is created and playwright is initialized.

The issue is that these particular test cases without using Browser require proxies, thus test case pauses, tries to connect to the playwright port and finally prints an error message. The test case itself passes, since no browser automation is used, anyway.

Describe the solution you'd like
As discussed with @Snooz82 the initialization of playwright on startup is only required on when using jsextensions. So a later initialization as default and immediate initialization for jsextensions may work.
@Snooz82 said making playwright a property would do the trick (whatever that means, i am merely a parrot 🦜 here)

@aaltat aaltat added enhancement New feature or request priority: high labels Sep 4, 2024
@aaltat
Copy link
Member

aaltat commented Sep 4, 2024

@allcontributors please @Noordsestern for ideas

@Snooz82 what was idea behind this request?

Copy link
Contributor

@aaltat

I could not determine your intention.

Basic usage: @all-contributors please add @Someone for code, doc and infra

For other usages see the documentation

@aaltat
Copy link
Member

aaltat commented Sep 4, 2024

@allcontributors please add @Noordsestern for ideas

Copy link
Contributor

@aaltat

I've put up a pull request to add @Noordsestern! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: high
Projects
None yet
Development

No branches or pull requests

2 participants