Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better feedback when hovering labels #2588

Closed
Incogdino opened this issue Jan 26, 2025 · 4 comments · Fixed by #2609
Closed

Better feedback when hovering labels #2588

Incogdino opened this issue Jan 26, 2025 · 4 comments · Fixed by #2609

Comments

@Incogdino
Copy link
Contributor

Please confirm that you have searched existing issues in the repo

Yes, I have searched the existing issues

Any related issues?

No response

What is the area that this feature belongs to?

Reader Usability

Is your feature request related to a problem? Please describe.

The current label for image annotations may not provide sufficient feedback to the user to indicate that it is a popup. When hovering over the annotation, the cursor does not change. An example is shown below:

Screen.Recording.2025-01-26.230451.mp4

Readers may be left unknown if there is no indication of a popover within the annotated image.

Describe the solution you'd like

Changing the cursor to a pointer when hovering over a label or anything within an Annotate Point.

Something like this should improve user experience when creating an annotated image.

20250126-1515-13.5793438.mp4

Describe alternatives you've considered

No response

Additional context

Would love to get any feedback on this or any potential implications this might cause!

@lhw-1
Copy link
Contributor

lhw-1 commented Jan 27, 2025

I think in general, when the cursor changes to a pointer, I would expect the UI component to be clickable (and it would do something on click).

Point taken though, I wonder if there are other alternatives we could look into for not just annotations, but similar components? E.g. changing the cursor to a question mark on hover? (Wouldn't be my first choice either, just an example.)

@lhw-1 lhw-1 added the s.UnderDiscussion The team will evaluate this issue to decide whether it is worth adding label Jan 27, 2025
@damithc
Copy link
Contributor

damithc commented Jan 27, 2025

Elsewhere in MarkBind, the convention is, dotted underline indicates the presence of a pop-up that appears on hover (i.e., no need to click) while a dashed underline indicates a pop-up that requires clicking to be revealed.
You can see an example in the landing page https://markbind.org

@lhw-1
Copy link
Contributor

lhw-1 commented Feb 1, 2025

My mistake, I realized that this is a popover and not a tooltip (i.e. it requires a click). We should follow the current conventions as mentioned by @damithc and change the labels to dashed underlined text & change the cursor to a pointer on hover.

@lhw-1 lhw-1 added f-Diagrams d.easy and removed s.UnderDiscussion The team will evaluate this issue to decide whether it is worth adding labels Feb 1, 2025
@Incogdino
Copy link
Contributor Author

My mistake, I realized that this is a popover and not a tooltip (i.e. it requires a click). We should follow the current conventions as mentioned by @damithc and change the labels to dashed underlined text & change the cursor to a pointer on hover.

In my opinion, it is more feasible to add show the intention with a cursor instead of a dasshed underlined especially in the case of image annotations.

20250217-0810-02.5895481.mp4

The case for dashed underline seems to be more appropriate if the target is going to be only text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants