Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support data table plugin in offline mode #2549

Closed
damithc opened this issue May 7, 2024 · 2 comments
Closed

Support data table plugin in offline mode #2549

damithc opened this issue May 7, 2024 · 2 comments
Assignees
Labels
p.Medium s.UnderDiscussion The team will evaluate this issue to decide whether it is worth adding

Comments

@damithc
Copy link
Contributor

damithc commented May 7, 2024

Similar to #2548

Perhaps render it as a normal table if there is no Internet access?

@damithc damithc added p.Medium s.UnderDiscussion The team will evaluate this issue to decide whether it is worth adding labels May 7, 2024
@yyccbb yyccbb self-assigned this Jan 20, 2025
@gerteck
Copy link
Contributor

gerteck commented Mar 10, 2025

Based on my work refactoring the dataTable plugin, I believe that the dataTable plugin is already supported offline in the initial PR2446 adding the plugin.

The binary file is included in our core package:

/*
* This combined file was created by the DataTables downloader builder:
* https://datatables.net/download
*
* To rebuild or modify this file with the latest versions of the included
* software please visit:
* https://datatables.net/download/#bs5/jq-3.7.0/dt-2.0.2
*
* Included libraries:
* jQuery 3 3.7.0, DataTables 2.0.2
*/

Here's a test showing it works offline (🌐 disabled).

Image

I think the decision to make dataTable available offline was because the js binary is quite small in comparison to mermaid js binary.

However, Mermaid diagrams aren't currently supported offline. I think we could focus on that.

@gerteck gerteck closed this as completed Mar 10, 2025
@damithc
Copy link
Contributor Author

damithc commented Mar 11, 2025

Thanks for checking this, @gerteck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p.Medium s.UnderDiscussion The team will evaluate this issue to decide whether it is worth adding
Projects
None yet
Development

No branches or pull requests

3 participants