Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug about fteik3d #2

Open
Liuyaguangzz opened this issue Dec 10, 2023 · 4 comments
Open

Bug about fteik3d #2

Liuyaguangzz opened this issue Dec 10, 2023 · 4 comments

Comments

@Liuyaguangzz
Copy link

Dear Dr.Noble

Thanks for sharing this package.

While using it, I noticed that there are some bugs in the 3D program.

When setting the source on the boundary of the 3D medium, it will return an incorrect result.

Such as I have a grid $501\times501\times501$, and I set the $dx=dy=dz=5$. I set 9 source point , list as:

zsrc xsrc ysrc
0 0 0
0 0 0
0 0 0
0 0 0
0 0 0
@Liuyaguangzz
Copy link
Author

Dear Dr.Noble

Thanks for sharing this package.

While using it, I noticed that there are some bugs in the 3D program.

When setting the source on the boundary of the 3D medium, it will return an incorrect result.

Such as I have a grid $501\times501\times501$, and I set the $dx=dy=dz=5$. I set 9 source point , list as:

zsrc xsrc ysrc
0 0 0
0 1250 0
0 2500 0
0 0 1250
0 1250 1250
0 2500 1250
0 0 2500
0 1250 2500
0 2500 2500

For the first, second, fourth, and fifth source points, the maximum boundary point is not reached, and the results are normal. For example, the top slice of the three-dimensional travel time field corresponding to the second source point shown below

微信截图_20231210210454

But for the remaining source points reaching the maximum boundary, the calculated travel time field results are puzzling, such as the 3rd source point and the 8th source point shown below

3rd

微信截图_20231210210738

8th
微信截图_20231210210817

I haven't found the reason yet. I hope you can take a look at what the problem is or whether I made some low-level mistakes. Thank you.

@Mark-Noble
Copy link
Owner

Thank you very much for pointing out the problem. Sources placed on far side edge were creating problems.
I hope I have fixed it, modifications where done in the file fteik3d.f90. You'll need to download this routine and recompile code.
Hope the problem is solved. You are using Su ximage, you can also use xcontour to clearly visualize wavefronts.
A new version of the Eikonal, more accurate is under test and I hope to drop in Github very soon.

@Mark-Noble
Copy link
Owner

Please confirm if problem is fixed

@Liuyaguangzz
Copy link
Author

Thank you very much for fixing this, and thank you for the recommended display tool xcontour.
I have test it, and the problem has been solved.
However, I still have a little confusion. When the source is at the boundary, the minimum value of the travel time field is not zero but 2.5e-7, but when the source is inside, the minimum value is zero, but this has nothing to do with it, it is just a small error.
Thank you very much!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants