Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests #8

Open
thomcc opened this issue Apr 13, 2020 · 1 comment
Open

Improve tests #8

thomcc opened this issue Apr 13, 2020 · 1 comment

Comments

@thomcc
Copy link
Contributor

thomcc commented Apr 13, 2020

Test coverage here is pretty abysmal. Filing a bug to record that it should be improved.

The stdlib has some tests for Arc functionality we could borrow in https://github.com/rust-lang/rust/blob/master/src/liballoc/sync/tests.rs, but a lot of them test things we don't really support like weak references.

They also don't test any of our bespoke artisanal smart pointers.

It would also be nice to run tests under loom once we actually have tests.
@Manishearth
Copy link
Owner

This would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomcc @Manishearth