promote SupportsFeatureMixin to a global phenomenon

kbrock · kbrock · commit bfbecf97d8d7 · 2024-08-22T16:45:15.000-04:00
Adding supports feature to a few more core models.
It makes sense to have this as a base class for all
diff --git a/app/models/application_record.rb b/app/models/application_record.rb
@@ -12,6 +12,7 @@ class ApplicationRecord < ActiveRecord::Base
   include ArHrefSlug
   include ToModelHash
   include ArVisibleAttribute
+  include SupportsFeatureMixin
 
   extend ArTableLock
   extend ArReferences
diff --git a/app/models/authentication.rb b/app/models/authentication.rb
@@ -2,7 +2,6 @@ class Authentication < ApplicationRecord
   acts_as_miq_taggable
   include ImportExport
   include YamlImportExportMixin
-  include SupportsFeatureMixin
   include NewWithTypeStiMixin
   def self.new(*args, &block)
     if self == Authentication && (args.empty? || args.first.kind_of?(Hash))
diff --git a/app/models/availability_zone.rb b/app/models/availability_zone.rb
@@ -1,5 +1,4 @@
 class AvailabilityZone < ApplicationRecord
-  include SupportsFeatureMixin
   include NewWithTypeStiMixin
   include Metric::CiMixin
   include EventMixin
diff --git a/app/models/cloud_database.rb b/app/models/cloud_database.rb
@@ -2,7 +2,6 @@ class CloudDatabase < ApplicationRecord
   include AsyncDeleteMixin
   include NewWithTypeStiMixin
   include ProviderObjectMixin
-  include SupportsFeatureMixin
 
   belongs_to :ext_management_system, :foreign_key => :ems_id, :class_name => "ManageIQ::Providers::CloudManager"
   belongs_to :cloud_tenant
diff --git a/app/models/cloud_network.rb b/app/models/cloud_network.rb
@@ -1,6 +1,5 @@
 class CloudNetwork < ApplicationRecord
   include NewWithTypeStiMixin
-  include SupportsFeatureMixin
   include CloudTenancyMixin
   include CustomActionsMixin
 
diff --git a/app/models/cloud_object_store_container.rb b/app/models/cloud_object_store_container.rb
@@ -9,7 +9,6 @@ class CloudObjectStoreContainer < ApplicationRecord
   include ProviderObjectMixin
   include NewWithTypeStiMixin
   include ProcessTasksMixin
-  include SupportsFeatureMixin
   include CustomActionsMixin
 
   include Operations
diff --git a/app/models/cloud_object_store_object.rb b/app/models/cloud_object_store_object.rb
@@ -9,7 +9,6 @@ class CloudObjectStoreObject < ApplicationRecord
   include ProviderObjectMixin
   include NewWithTypeStiMixin
   include ProcessTasksMixin
-  include SupportsFeatureMixin
 
   include Operations
 
diff --git a/app/models/cloud_subnet.rb b/app/models/cloud_subnet.rb
@@ -1,6 +1,5 @@
 class CloudSubnet < ApplicationRecord
   include NewWithTypeStiMixin
-  include SupportsFeatureMixin
   include CloudTenancyMixin
   include CustomActionsMixin
 
diff --git a/app/models/cloud_volume.rb b/app/models/cloud_volume.rb
@@ -2,7 +2,6 @@ class CloudVolume < ApplicationRecord
   include NewWithTypeStiMixin
   include ProviderObjectMixin
   include AsyncDeleteMixin
-  include SupportsFeatureMixin
   include CloudTenancyMixin
   include CustomActionsMixin
   include EmsRefreshMixin
diff --git a/app/models/cloud_volume_backup.rb b/app/models/cloud_volume_backup.rb
@@ -1,7 +1,6 @@
 class CloudVolumeBackup < ApplicationRecord
   include NewWithTypeStiMixin
   include ProviderObjectMixin
-  include SupportsFeatureMixin
   include CloudTenancyMixin
 
   acts_as_miq_taggable
diff --git a/app/models/cloud_volume_snapshot.rb b/app/models/cloud_volume_snapshot.rb
@@ -1,7 +1,6 @@
 class CloudVolumeSnapshot < ApplicationRecord
   include NewWithTypeStiMixin
   include ProviderObjectMixin
-  include SupportsFeatureMixin
   include CloudTenancyMixin
   include CustomActionsMixin
   include EmsRefreshMixin
diff --git a/app/models/configuration_profile.rb b/app/models/configuration_profile.rb
@@ -1,6 +1,5 @@
 class ConfigurationProfile < ApplicationRecord
   include NewWithTypeStiMixin
-  include SupportsFeatureMixin
 
   acts_as_miq_taggable
   belongs_to :manager, :class_name => 'ExtManagementSystem'
diff --git a/app/models/configuration_script_base.rb b/app/models/configuration_script_base.rb
@@ -23,5 +23,4 @@ class ConfigurationScriptBase < ApplicationRecord
   scope :with_manager, ->(manager_id) { where(:manager_id => manager_id) }
 
   include ProviderObjectMixin
-  include SupportsFeatureMixin
 end
diff --git a/app/models/configuration_script_source.rb b/app/models/configuration_script_source.rb
@@ -1,8 +1,6 @@
 class ConfigurationScriptSource < ApplicationRecord
   acts_as_miq_taggable
 
-  include SupportsFeatureMixin
-
   has_many    :configuration_script_payloads, :dependent => :destroy
   belongs_to  :authentication
   belongs_to  :manager, :class_name => "ExtManagementSystem"
diff --git a/app/models/configured_system.rb b/app/models/configured_system.rb
@@ -1,6 +1,5 @@
 class ConfiguredSystem < ApplicationRecord
   include NewWithTypeStiMixin
-  include SupportsFeatureMixin
   include CustomAttributeMixin
 
   acts_as_miq_taggable
diff --git a/app/models/container.rb b/app/models/container.rb
@@ -1,5 +1,4 @@
 class Container < ApplicationRecord
-  include SupportsFeatureMixin
   include NewWithTypeStiMixin
   include ArchivedMixin
   include Purging
diff --git a/app/models/container_group.rb b/app/models/container_group.rb
@@ -1,7 +1,6 @@
 class ContainerGroup < ApplicationRecord
   acts_as_miq_taggable
 
-  include SupportsFeatureMixin
   include ComplianceMixin
   include CustomAttributeMixin
   include MiqPolicyMixin
diff --git a/app/models/container_image.rb b/app/models/container_image.rb
@@ -1,7 +1,6 @@
 class ContainerImage < ApplicationRecord
   acts_as_miq_taggable
 
-  include SupportsFeatureMixin
   include ComplianceMixin
   include MiqPolicyMixin
   include ScanningMixin
diff --git a/app/models/container_node.rb b/app/models/container_node.rb
@@ -1,12 +1,10 @@
 class ContainerNode < ApplicationRecord
   acts_as_miq_taggable
 
-  include SupportsFeatureMixin
   include ComplianceMixin
   include MiqPolicyMixin
   include NewWithTypeStiMixin
   include TenantIdentityMixin
-  include SupportsFeatureMixin
   include ArchivedMixin
   include CustomActionsMixin
   include Purging
diff --git a/app/models/container_project.rb b/app/models/container_project.rb
@@ -1,7 +1,6 @@
 class ContainerProject < ApplicationRecord
   acts_as_miq_taggable
 
-  include SupportsFeatureMixin
   include CustomAttributeMixin
   include ArchivedMixin
   include MiqPolicyMixin
diff --git a/app/models/container_replicator.rb b/app/models/container_replicator.rb
@@ -1,7 +1,6 @@
 class ContainerReplicator < ApplicationRecord
   acts_as_miq_taggable
 
-  include SupportsFeatureMixin
   include ComplianceMixin
   include CustomAttributeMixin
   include MiqPolicyMixin
diff --git a/app/models/container_service.rb b/app/models/container_service.rb
@@ -1,6 +1,5 @@
 class ContainerService < ApplicationRecord
   include CustomAttributeMixin
-  include SupportsFeatureMixin
   # :name, :uid, :creation_timestamp, :resource_version, :namespace
   # :labels, :selector, :protocol, :port, :container_port, :portal_ip, :session_affinity
 
diff --git a/app/models/container_template.rb b/app/models/container_template.rb
@@ -1,7 +1,6 @@
 class ContainerTemplate < ApplicationRecord
   include CustomAttributeMixin
   include CustomActionsMixin
-  include SupportsFeatureMixin
 
   belongs_to :ext_management_system, :foreign_key => "ems_id"
   belongs_to :container_project
diff --git a/app/models/ems_cluster.rb b/app/models/ems_cluster.rb
@@ -1,5 +1,4 @@
 class EmsCluster < ApplicationRecord
-  include SupportsFeatureMixin
   include NewWithTypeStiMixin
   include EventMixin
   include TenantIdentityMixin
diff --git a/app/models/ext_management_system.rb b/app/models/ext_management_system.rb
@@ -1,6 +1,5 @@
 class ExtManagementSystem < ApplicationRecord
   include CustomActionsMixin
-  include SupportsFeatureMixin
   include ExternalUrlMixin
   include VerifyCredentialsMixin
   include SupportsAttribute
@@ -200,7 +199,6 @@ def validate_zone_not_maintenance_when_ems_enabled?
   include UuidMixin
   include EmsRefresh::Manager
   include TenancyMixin
-  include SupportsFeatureMixin
   include ComplianceMixin
   include CustomAttributeMixin
 
diff --git a/app/models/flavor.rb b/app/models/flavor.rb
@@ -1,7 +1,6 @@
 class Flavor < ApplicationRecord
   include NewWithTypeStiMixin
   include CloudTenancyMixin
-  include SupportsFeatureMixin
 
   acts_as_miq_taggable
 
diff --git a/app/models/floating_ip.rb b/app/models/floating_ip.rb
@@ -1,6 +1,5 @@
 class FloatingIp < ApplicationRecord
   include NewWithTypeStiMixin
-  include SupportsFeatureMixin
   include CloudTenancyMixin
 
   acts_as_miq_taggable
diff --git a/app/models/host.rb b/app/models/host.rb
@@ -6,7 +6,6 @@
 require 'metadata/ScanProfile/HostScanProfiles'
 
 class Host < ApplicationRecord
-  include SupportsFeatureMixin
   include NewWithTypeStiMixin
   include TenantIdentityMixin
   include DeprecationMixin
diff --git a/app/models/host_aggregate.rb b/app/models/host_aggregate.rb
@@ -1,5 +1,4 @@
 class HostAggregate < ApplicationRecord
-  include SupportsFeatureMixin
   include NewWithTypeStiMixin
   include Metric::CiMixin
   include EventMixin
diff --git a/app/models/host_initiator.rb b/app/models/host_initiator.rb
@@ -1,7 +1,6 @@
 class HostInitiator < ApplicationRecord
   include NewWithTypeStiMixin
   include ProviderObjectMixin
-  include SupportsFeatureMixin
   include CustomActionsMixin
   include EmsRefreshMixin
 
diff --git a/app/models/host_initiator_group.rb b/app/models/host_initiator_group.rb
@@ -1,7 +1,6 @@
 class HostInitiatorGroup < ApplicationRecord
   include NewWithTypeStiMixin
   include ProviderObjectMixin
-  include SupportsFeatureMixin
   include CustomActionsMixin
   include EmsRefreshMixin
 
diff --git a/app/models/manageiq/providers/container_manager.rb b/app/models/manageiq/providers/container_manager.rb
@@ -1,6 +1,5 @@
 module ManageIQ::Providers
   class ContainerManager < BaseManager
-    include SupportsFeatureMixin
 
     has_many :container_nodes, -> { active }, # rubocop:disable Rails/HasManyOrHasOneDependent
              :foreign_key => :ems_id,
diff --git a/app/models/manageiq/providers/infra_manager.rb b/app/models/manageiq/providers/infra_manager.rb
@@ -1,7 +1,5 @@
 module ManageIQ::Providers
   class InfraManager < BaseManager
-    include SupportsFeatureMixin
-
     has_many :distributed_virtual_switches, :dependent => :destroy, :foreign_key => :ems_id, :inverse_of => :ext_management_system
     has_many :distributed_virtual_lans, -> { distinct }, :through => :distributed_virtual_switches, :source => :lans
     has_many :host_virtual_switches, -> { distinct }, :through => :hosts
diff --git a/app/models/manageiq/providers/network_manager.rb b/app/models/manageiq/providers/network_manager.rb
@@ -1,7 +1,5 @@
 module ManageIQ::Providers
   class NetworkManager < BaseManager
-    include SupportsFeatureMixin
-
     PROVIDER_NAME = "Network Manager".freeze
 
     class << model_name
diff --git a/app/models/manageiq/providers/physical_infra_manager.rb b/app/models/manageiq/providers/physical_infra_manager.rb
@@ -1,7 +1,5 @@
 module ManageIQ::Providers
   class PhysicalInfraManager < BaseManager
-    include SupportsFeatureMixin
-
     has_many :physical_chassis,  :foreign_key => "ems_id", :dependent => :destroy, :inverse_of => :ext_management_system
     has_many :physical_racks,    :foreign_key => "ems_id", :dependent => :destroy, :inverse_of => :ext_management_system
     has_many :physical_servers,  :foreign_key => "ems_id", :dependent => :destroy, :inverse_of => :ext_management_system
diff --git a/app/models/manageiq/providers/storage_manager.rb b/app/models/manageiq/providers/storage_manager.rb
@@ -1,7 +1,5 @@
 module ManageIQ::Providers
   class StorageManager < ManageIQ::Providers::BaseManager
-    include SupportsFeatureMixin
-
     has_many :cloud_tenants, :foreign_key => :ems_id, :dependent => :destroy
     has_many :volume_availability_zones, :class_name => "AvailabilityZone", :foreign_key => :ems_id, :dependent => :destroy
 
diff --git a/app/models/miq_enterprise.rb b/app/models/miq_enterprise.rb
@@ -16,7 +16,6 @@ class MiqEnterprise < ApplicationRecord
 
   acts_as_miq_taggable
 
-  include SupportsFeatureMixin
   include MiqPolicyMixin
   include Metric::CiMixin
 
diff --git a/app/models/miq_region.rb b/app/models/miq_region.rb
@@ -26,7 +26,6 @@ class MiqRegion < ApplicationRecord
   include ConfigurationManagementMixin
 
   include MiqPolicyMixin
-  include SupportsFeatureMixin
   include Metric::CiMixin
 
   alias_method :all_storages,           :storages
diff --git a/app/models/network_router.rb b/app/models/network_router.rb
@@ -1,6 +1,5 @@
 class NetworkRouter < ApplicationRecord
   include NewWithTypeStiMixin
-  include SupportsFeatureMixin
   include CloudTenancyMixin
   include CustomActionsMixin
 
diff --git a/app/models/network_service.rb b/app/models/network_service.rb
@@ -1,6 +1,5 @@
 class NetworkService < ApplicationRecord
   include NewWithTypeStiMixin
-  include SupportsFeatureMixin
   include CloudTenancyMixin
   include CustomActionsMixin
 
diff --git a/app/models/network_service_entry.rb b/app/models/network_service_entry.rb
@@ -1,6 +1,5 @@
 class NetworkServiceEntry < ApplicationRecord
   include NewWithTypeStiMixin
-  include SupportsFeatureMixin
   include CloudTenancyMixin
   include CustomActionsMixin
 
diff --git a/app/models/orchestration_stack.rb b/app/models/orchestration_stack.rb
@@ -8,7 +8,6 @@ class OrchestrationStack < ApplicationRecord
   include RetirementMixin
   include TenantIdentityMixin
   include CustomActionsMixin
-  include SupportsFeatureMixin
   include CiFeatureMixin
   include CloudTenancyMixin
   include EmsRefreshMixin
diff --git a/app/models/orchestration_template.rb b/app/models/orchestration_template.rb
@@ -1,6 +1,5 @@
 require 'digest/md5'
 class OrchestrationTemplate < ApplicationRecord
-  include SupportsFeatureMixin
   include NewWithTypeStiMixin
 
   acts_as_miq_taggable
diff --git a/app/models/physical_chassis.rb b/app/models/physical_chassis.rb
@@ -1,5 +1,4 @@
 class PhysicalChassis < ApplicationRecord
-  include SupportsFeatureMixin
   include EventMixin
   include EmsRefreshMixin
   include CustomActionsMixin
diff --git a/app/models/physical_rack.rb b/app/models/physical_rack.rb
@@ -1,5 +1,4 @@
 class PhysicalRack < ApplicationRecord
-  include SupportsFeatureMixin
   include EmsRefreshMixin
   include CustomActionsMixin
 
diff --git a/app/models/physical_server.rb b/app/models/physical_server.rb
@@ -4,7 +4,6 @@ class PhysicalServer < ApplicationRecord
   include NewWithTypeStiMixin
   include MiqPolicyMixin
   include TenantIdentityMixin
-  include SupportsFeatureMixin
   include EventMixin
   include ProviderObjectMixin
   include ComplianceMixin
diff --git a/app/models/physical_server_profile.rb b/app/models/physical_server_profile.rb
@@ -3,7 +3,6 @@ class PhysicalServerProfile < ApplicationRecord
 
   include NewWithTypeStiMixin
   include TenantIdentityMixin
-  include SupportsFeatureMixin
   include EventMixin
   include ProviderObjectMixin
   include EmsRefreshMixin
diff --git a/app/models/physical_server_profile_template.rb b/app/models/physical_server_profile_template.rb
@@ -3,7 +3,6 @@ class PhysicalServerProfileTemplate < ApplicationRecord
 
   include NewWithTypeStiMixin
   include TenantIdentityMixin
-  include SupportsFeatureMixin
   include ProviderObjectMixin
   include EmsRefreshMixin
 
diff --git a/app/models/physical_storage.rb b/app/models/physical_storage.rb
@@ -1,8 +1,6 @@
 class PhysicalStorage < ApplicationRecord
-  include SupportsFeatureMixin
   include NewWithTypeStiMixin
   include ProviderObjectMixin
-  include SupportsFeatureMixin
   include CustomActionsMixin
   include EmsRefreshMixin
   include EventMixin
diff --git a/app/models/physical_storage_family.rb b/app/models/physical_storage_family.rb
@@ -1,6 +1,5 @@
 class PhysicalStorageFamily < ApplicationRecord
   include ProviderObjectMixin
-  include SupportsFeatureMixin
 
   belongs_to :ext_management_system, :foreign_key => :ems_id
   has_many :physical_storages, :dependent => :nullify
diff --git a/app/models/physical_switch.rb b/app/models/physical_switch.rb
@@ -1,5 +1,4 @@
 class PhysicalSwitch < Switch
-  include SupportsFeatureMixin
   include EventMixin
   include EmsRefreshMixin
 
diff --git a/app/models/placement_group.rb b/app/models/placement_group.rb
diff --git a/app/models/provider.rb b/app/models/provider.rb
diff --git a/app/models/security_group.rb b/app/models/security_group.rb
diff --git a/app/models/security_policy.rb b/app/models/security_policy.rb
diff --git a/app/models/security_policy_rule.rb b/app/models/security_policy_rule.rb
diff --git a/app/models/service.rb b/app/models/service.rb
diff --git a/app/models/service_template.rb b/app/models/service_template.rb
diff --git a/app/models/storage.rb b/app/models/storage.rb
diff --git a/app/models/storage_resource.rb b/app/models/storage_resource.rb
diff --git a/app/models/storage_service.rb b/app/models/storage_service.rb
diff --git a/app/models/vm_or_template.rb b/app/models/vm_or_template.rb
diff --git a/app/models/volume_mapping.rb b/app/models/volume_mapping.rb
diff --git a/app/models/zone.rb b/app/models/zone.rb

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`class AvailabilityZone < ApplicationRecord`
`2`		`- include SupportsFeatureMixin`
`3`	`2`	`include NewWithTypeStiMixin`
`4`	`3`	`include Metric::CiMixin`
`5`	`4`	`include EventMixin`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`class Container < ApplicationRecord`
`2`		`- include SupportsFeatureMixin`
`3`	`2`	`include NewWithTypeStiMixin`
`4`	`3`	`include ArchivedMixin`
`5`	`4`	`include Purging`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`class EmsCluster < ApplicationRecord`
`2`		`- include SupportsFeatureMixin`
`3`	`2`	`include NewWithTypeStiMixin`
`4`	`3`	`include EventMixin`
`5`	`4`	`include TenantIdentityMixin`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`class HostAggregate < ApplicationRecord`
`2`		`- include SupportsFeatureMixin`
`3`	`2`	`include NewWithTypeStiMixin`
`4`	`3`	`include Metric::CiMixin`
`5`	`4`	`include EventMixin`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`class PhysicalChassis < ApplicationRecord`
`2`		`- include SupportsFeatureMixin`
`3`	`2`	`include EventMixin`
`4`	`3`	`include EmsRefreshMixin`
`5`	`4`	`include CustomActionsMixin`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`class PhysicalRack < ApplicationRecord`
`2`		`- include SupportsFeatureMixin`
`3`	`2`	`include EmsRefreshMixin`
`4`	`3`	`include CustomActionsMixin`
`5`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`class PhysicalSwitch < Switch`
`2`		`- include SupportsFeatureMixin`
`3`	`2`	`include EventMixin`
`4`	`3`	`include EmsRefreshMixin`
`5`	`4`