Fix generic object embedded table #9266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GilbertCherrie
force-pushed
the
fix_go_embedded_table
branch
from
6d70216
to
df1d953
Compare
Fryguy
reviewed
Oct 29, 2024
Fryguy
reviewed
Oct 29, 2024
|
@Fryguy I fixed both the suggested fixes if you can review again when you have time |
GilbertCherrie
force-pushed
the
fix_go_embedded_table
branch
from
119fd47
to
f1677a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9255
Fixed generic object embedded table. Also, fixed the toolbar for the embedded generic object table page.
This pr also fixes an issue where custom buttons do not appear on the generic object show page.
Before:
After:
