Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource pools CPU usage/availability shown as integers not float #108

Closed
vfebvre opened this issue Oct 19, 2022 · 6 comments · Fixed by ManageIQ/manageiq-schema#708
Closed
Assignees
Labels
enhancement New feature or request stale

Comments

@vfebvre
Copy link
Contributor

vfebvre commented Oct 19, 2022

Following merge of #100 to include HMC Shared Processor Pools in the inventory as Resource Pools :

  • CPU Reserve/Share values stored in the resource_pools table are integers and not accurate as actual values from the HMC can include fraction of a CPU (granularity of 0.01).
vmdb_development=# \d+ resource_pools
                                                                  Table "public.resource_pools"
        Column         |            Type             | Collation | Nullable |                  Default                   | Storage  | Stats target | Description
-----------------------+-----------------------------+-----------+----------+--------------------------------------------+----------+--------------+-------------
 id                    | bigint                      |           | not null | nextval('resource_pools_id_seq'::regclass) | plain    |              |
 name                  | character varying           |           |          |                                            | extended |              |
...
 cpu_reserve           | integer                     |           |          |                                            | plain    |              |
 cpu_reserve_expand    | boolean                     |           |          |                                            | plain    |              |
 cpu_limit             | integer                     |           |          |                                            | plain    |              |
 cpu_shares            | integer                     |           |          |                                            | plain    |              |
 cpu_shares_level      | character varying           |           |          |                                            | extended |              |
...

In the example below, CPU Reserve should be 1.3 and Shares 1.7

image
image
image

@Fryguy
Copy link
Member

Fryguy commented Dec 6, 2022

Discussion about whether we should do this over in the schema PR 👉 ManageIQ/manageiq-schema#675 (comment)

@miq-bot miq-bot added the stale label Mar 13, 2023
@miq-bot
Copy link
Member

miq-bot commented Mar 13, 2023

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@miq-bot
Copy link
Member

miq-bot commented Jun 19, 2023

This issue has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this issue if this issue is still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@miq-bot miq-bot closed this as completed Jun 19, 2023
@jaywcarman
Copy link
Member

This issue is still valid... re-opening.

@jaywcarman jaywcarman reopened this Jul 17, 2023
@miq-bot miq-bot closed this as completed Oct 23, 2023
@miq-bot
Copy link
Member

miq-bot commented Oct 23, 2023

This issue has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this issue if this issue is still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@jaywcarman
Copy link
Member

Fixed by ManageIQ/manageiq-schema#708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants