Differentiate between Kubevirt and OpenShift Virtualization #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
reviewed
Sep 25, 2024
| | Events | ✅ | ✅ | ✅ | ✅ | ❌ | | ||
| | Metrics | ✅ | ✅ | ✅ | ✅ | ❌ | | ||
| | Forensic Analysis (SmartState) | ✅ | ✅ | ✅ (Nodes) | ❌ | ❌ | | ||
| | Discovery | vSphere | oVirt / RHV | OpenStack undercloud | IBM Power HMC | KubeVirt | OSV | |
There was a problem hiding this comment.
So we show the other subclassed providers together, oVirt / RHV
Could we do | KubeVirt / OSV | at least until we have any differentiation between the two in features supported
There was a problem hiding this comment.
I think we still need to update the capability matrix with KubeVirt / OSV
There was a problem hiding this comment.
That is there https://github.com/ManageIQ/manageiq-documentation/blob/master/capabilities_matrix/_topics/infrastructure_providers.md, the earlier change was just to separate it but no longer doing that
There was a problem hiding this comment.
🤦 I didn't see that in the diff, thanks
nasark
force-pushed
the
osv_provider_changes
branch
from
66a5eea
to
3b98672
Compare
agrare
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post subclassing OSV, we should differentiate it as a separate provider from Kubevirt in the docs
@miq-bot assign @agrare
@miq-bot add_labels enhancement, radjabov/yes?
@miq-bot add_reviewers @agrare, @Fryguy