Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some URLs don't work, despite having Open Graph tags #16

Open
ChrisBegley opened this issue Jul 31, 2024 · 4 comments
Open

Some URLs don't work, despite having Open Graph tags #16

ChrisBegley opened this issue Jul 31, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@ChrisBegley
Copy link

ChrisBegley commented Jul 31, 2024

Thank you for making this plugin, it's exactly what I was looking for. It was recommended to me by a viewer of a live stream between Jamie Marsland and Mike McAlister yesterday.

I've noticed that some URLs don't pull in an image, despite having the necessary Open Graph tags (like og:image). Other URLs don't work at all, again despite having Open Graph tags.

Examples of URLs that work, but don't pull in an image:
https://www.hollywoodreporter.com/movies/movie-news/superman-james-gunn-wraps-filming-1235962379/
https://variety.com/2024/film/news/robert-downey-jr-doctor-doom-avengers-pay-salary-russo-brothers-1236089512/
https://deadline.com/2024/07/sag-aftra-picket-video-game-strike-warner-bros-1236026963/

Examples of URLs that don't work at all:
https://collider.com/x-men-comic-accurate-costumes-explained-hugh-jackman/
https://screenrant.com/mcu-san-diego-comic-con-2024-reveals-video/

@Mamaduka Mamaduka added the bug Something isn't working label Jul 31, 2024
@Mamaduka
Copy link
Owner

Thank you, @ChrisBegley!

The block uses the wp-block-editor/v1/url-details REST API endpoint under the hook. It's an official WP API for parsing remote URLs. If it can parse the site, the block can render.

I need to test why these URLs are failing and will report the bug/patch upstream. Unfortunately, we might need to wait until WP 6.7 to fix this.

@ChrisBegley
Copy link
Author

ChrisBegley commented Jul 31, 2024

Thanks! And thanks for the explanation on how it all works.

I also have one small feature request... would it be possible to add loading="lazy" to the image tag? I'm thinking of creating a Twitter-style micro blog so I'll have a lot of Bookmark Cards on the homepage.

I can create a new "issue" for that one if it's something you want to add.

@Mamaduka
Copy link
Owner

Sure. I can look into lazy-loading images. A separate issue would be perfect (primarily for tracking purposes).

Thanks, @ChrisBegley!

@ChrisBegley
Copy link
Author

ChrisBegley commented Jul 31, 2024

Thanks @Mamaduka! I just added the enhancement request: #17

and thanks again for this awesome plugin. It'd be nice if URLs embedded like this as part of core one day. I think it's a pretty slick way to show off a URL, and it's what people are used to seeing on social media.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants