Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visible option does not work with tricontourf! #4458

Open
3 tasks
baxmittens opened this issue Oct 7, 2024 · 1 comment
Open
3 tasks

Visible option does not work with tricontourf! #4458

baxmittens opened this issue Oct 7, 2024 · 1 comment
Labels
Attributes Plot, Block and Scene Attributes bug Makie Backend independent issues (Makie core) (tri)contour(f) not 3D contour, that's volume

Comments

@baxmittens
Copy link

  • what version of Makie are you running? Makie v0.21.13
  • can you reproduce the bug with a fresh environment ? Yes
  • What platform + GPU are you on? Tried this on Linux and on Mac OS

Here is my example:

using Bonito
using WGLMakie

app = App() do session::Session
	visible = Observable(true)
	dropdown = Bonito.Dropdown(["visible", "invisible"]; index=1)
    on(dropdown.value) do value
        if value=="visible"
        	visible[] = true
        	@info "should be visible"
        else
        	visible[] = false
        	@info "should be invisible"
        end
    end

	f = Figure(size=(1000,200))
	ax1 = Axis(f[1,1])
	ax2 = Axis(f[2,1])

	x = randn(50)
	y = randn(50)
	z = -sqrt.(x .^ 2 .+ y .^ 2) .+ 0.1 .* randn.()

	vertices = [
	    0.0 0.0;
	    1.0 0.0;
	    1.0 1.0;
	    0.0 1.0;
	]
	
	faces = [
	    1 2 3;
	    3 4 1;
	]

	colors = [:red, :green, :blue, :orange]

	tricontourf!(ax1, x, y, z, visible=visible)
	mesh!(ax2, vertices, faces, color = colors, shading = NoShading, visible=visible)
	
	return DOM.div(dropdown,f)
end

Image

Tried this with GLMakie as well with the same result.

Greetz max

@baxmittens baxmittens added the bug label Oct 7, 2024
@EdsterG
Copy link
Contributor

EdsterG commented Oct 7, 2024

Looks like the attribute isn't passed through, should be fixed by #4399.

@ffreyer ffreyer added Attributes Plot, Block and Scene Attributes Makie Backend independent issues (Makie core) (tri)contour(f) not 3D contour, that's volume labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Attributes Plot, Block and Scene Attributes bug Makie Backend independent issues (Makie core) (tri)contour(f) not 3D contour, that's volume
Projects
None yet
Development

No branches or pull requests

3 participants