support GeoJSON 0.7 #172
Merged
support GeoJSON 0.7 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The two test failures were already there, I made sure this didn't add new failures, and the example from the readme works with either GeoJSON version. |
|
Hi! Any problems to merge this PR? I am having problems because I need some functionality in Meshes.jl that requires GeoJSON 0.7. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new GeoJSON from JuliaGeo/GeoJSON.jl#63 is quite breaking, but for this package it seems quite limited, so both can be supported. The main different is that coordinates are no longer given as Vector of size 2 but as an NTuple{2, Float32}.
The geo2basic code needs to go at some point since both GeometryBasics and GeoJSON support the GeoInterface.
I noticed that CompatHelper has created one new branch per hour since the GeoJSON release, so now there are over 1000 branches. And I don't see a CompatHelper PR. Example: 75db288