Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPAIDFLash.swf doesn't work #208

Open
rq30 opened this issue May 10, 2016 · 14 comments
Open

VPAIDFLash.swf doesn't work #208

rq30 opened this issue May 10, 2016 · 14 comments

Comments

@rq30
Copy link

rq30 commented May 10, 2016

I am using similar code both for development version (where VPAIDFlash.swf is located locally) and production version (VPAIDFlash.swf on a server - nginx as reverse proxy). I am able to play Flash based creative locally but not in production version. It gives
AD ERROR: VAST Error: on VASTClient.getVASTAd.validateAd, could not find MediaFile that is supported by this video player i {message: "VAST Error: on VASTClient.getVASTAd.validateAd, co… MediaFile that is supported by this video player", code: 403} [a]

Only thing that has changed is the path of VPAIDFlash.swf.
Even tested the same behaviour on Amazon S3 :( any solution

@lpender
Copy link
Contributor

lpender commented May 10, 2016

The issue is when the reference to VPAIDFlash.swf is on a remote server ('http://' or '//'). It works in Chrome when the swf is local, it does not work in Firefox.

I wonder if this is a security ('https') issue

@rq30
Copy link
Author

rq30 commented May 11, 2016

Any solution to this?

@lpender
Copy link
Contributor

lpender commented May 11, 2016

Make sure Flash is installed

@Fetz
Copy link
Contributor

Fetz commented May 12, 2016

@rushanq do you get any network errors? Did you check if the paths of the generated swf object is pointing correctly?

@lpender
Copy link
Contributor

lpender commented May 12, 2016

Also, you might try compiling the 'bin' files from scratch by cloning the repo. The files that are currently committed don't appear to be generated from the latest source.

@lpender
Copy link
Contributor

lpender commented May 12, 2016

The latest source appears to be working for me

@rq30
Copy link
Author

rq30 commented May 12, 2016

@lpender I will try compiling from source. Also flash is installed if not then why its running Vpaid Swf creative when VPAIDFlash.swf is local and not on a CDN.
@Fetz Yes its pointing correctly.

var vpaidPath=config.paths.vastPluginDir + 'bin/VPAIDFlash.swf';
    videojs.plugin('ads-setup', function(opts) {
            var player = this;
            videoPlayer=player;
            var adsCancelTimeout = adxCancelTimeout;
            vastAd = player.vastClient({
                //Media tag URL
                adTagUrl: macroReplacement(vastTag_x1, target_x1),
                playAdAlways: true,
                //Note: As requested we set the preroll timeout at the same place than the adsCancelTimeout
                adCancelTimeout: adsCancelTimeout,
                vpaidFlashLoaderPath: vpaidPath,
                adsEnabled: true
            });

The only thing that changes is vpaidPath

@rq30
Copy link
Author

rq30 commented May 12, 2016

@lpender rebuilding from source fixed the issue. Its working now. Thanks a lot

@rq30 rq30 closed this as completed May 12, 2016
@rq30 rq30 reopened this May 12, 2016
@rq30 rq30 closed this as completed May 12, 2016
@lpender
Copy link
Contributor

lpender commented May 16, 2016

@rushanq fyi, after more extensive testing, I realized that the ads still fail with this message intermittently on the latest build.

I narrowed the issue down to a race condition in VPAIDFLASHClient:

MailOnline/VPAIDFLASHClient#17

Fwiw, the problem can be solved by hardwiring FlashTester.isSupported to return true.

@rq30 rq30 reopened this May 17, 2016
@Fetz
Copy link
Contributor

Fetz commented May 17, 2016

@lpender the flashTester is async by nature since is doing the following:
load a swf, if the swf is able to exchange messages with the js then pass the test (I'm doing this since swfobject will give false positives when Firefox blocks flash when is not the latest version).

So if you are playing a video in autoplay or "too soon" will not use flash in the first play. If is this what is happening, then I can had a feature to by default assumes that flash can play (if swfobject test pass and in the background really test if is true or not)

more details: #182

@indieocean
Copy link

We where having this problem when opening up the html file directly without hosting it via file://. Once we hosted it on a local server it worked perfectly.

@eprincen2
Copy link

Is there a way to kill this flash loader dependency? Flash is pretty much dead thankfully.

@prosv
Copy link

prosv commented Dec 21, 2016

I have the same problem.

@shachr
Copy link

shachr commented Apr 23, 2017

I have the same issue. not always working in production, it fails for many browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants