Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audible clicks in Chrome #12

Open
bentstamnes opened this issue Jun 29, 2016 · 4 comments
Open

Audible clicks in Chrome #12

bentstamnes opened this issue Jun 29, 2016 · 4 comments

Comments

@bentstamnes
Copy link

bentstamnes commented Jun 29, 2016

It appears as if the playback isn't faded either in nor out and that the playback is just immediately stopped (for example when re-clicking the demo button, or hovering over the other demo button and then moving the mouse pointer), which produces severe clicks.

There should probably be fading towards DC 0 to avoid these clicks, and that sounds like it should be in the playback library, and not rely on the audio files (which is probably impossible to maintain anyway, given that any sound can be stopped at any time :)

@MahdiF
Copy link
Owner

MahdiF commented Jun 29, 2016

I didn't write a fade in/out function, it stops the first sound and plays the next one when you hover/click something else.

@bentstamnes
Copy link
Author

Alright, so at least my intuition was right then. :) I think it would greatly benefit a sharp fade out on audio playback stop, especially since this seems to be directed at interface sounds which usually might not overlap much.

@MahdiF
Copy link
Owner

MahdiF commented Jun 29, 2016

That's actually a great suggestion! Thanks Bent :)

On Wed, Jun 29, 2016 at 2:14 PM, Bent Stamnes [email protected]
wrote:

Alright, so at least my intuition was right then. :) I think it would
greatly benefit a sharp fade out on audio playback stop, especially since
this seems to be directed at interface sounds which usually might not
overlap much.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AEArpTQYtFql850cJNQ3s5pAj2lBN5uvks5qQmGvgaJpZM4JBEHH
.

@bentstamnes
Copy link
Author

Happy to suggest it! 👍 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants