Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize system/moveset? #98

Open
rsdefever opened this issue May 5, 2021 · 2 comments
Open

Serialize system/moveset? #98

rsdefever opened this issue May 5, 2021 · 2 comments
Assignees

Comments

@rsdefever
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

  1. Would it be useful to serialize the system and moveset?
  2. If yes, what is the best way to do this? Pickle? Or do we need something fancier?
@rmatsum836
Copy link
Collaborator

  1. I think this would be a useful feature.
  2. It depends on what you would want from the serialized objects. If you're not worried about human readability, pickle might be fine. Otherwise, something like JSON might be better. mBuild uses Google's protobuf but I don't exactly remember the motivations for doing so.

@rsdefever
Copy link
Collaborator Author

rsdefever commented May 5, 2021

  1. What is the use case? I'm not trying to shoot down my own idea I'm just trying to think it through. Create a system once and then reuse it for several different simulations? We don't need the system or moveset for mc.restart() anymore. The read frame analysis feature in Add load_final_frame to analysis module to facilitate MC-MD workflows #97 might require the System, depending on how it is implemented. Any other features/use cases that would require it? Also, given how closely related the System and MoveSet are, it might be dangerous to serialize them separately.
  2. I don't think I care about it being human readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants