Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul mcfgen.py and library_setup.py #79

Open
rsdefever opened this issue Aug 20, 2020 · 0 comments
Open

Overhaul mcfgen.py and library_setup.py #79

rsdefever opened this issue Aug 20, 2020 · 0 comments

Comments

@rsdefever
Copy link
Collaborator

rsdefever commented Aug 20, 2020

A few months back I wrote an overhaul to mcfgen.py and library_setup.py. See numbers #32 and #33 for the code and reference. I have refrained from merging the changes into the main repository because I am concerned that the updated scripts have not yet had adequate testing. I propose we move forward with integrating these into the repository but first add pytest-based unit testing on these two scripts. See #83 for further motivation.

This overhaul will also move us to python3 for both scripts. We have now included a python2 deprecation warning with both scripts for a couple of releases but I nonetheless propose that we continue to publish the python2 compatible versions of the scripts at least for another release or two, at which time they would be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant