Issues of cell management testing #298

silySuper · 2023-10-13T02:34:17Z

These issues found in light client mode.
1.Icon shows wrong.
UI document:

Actual:

2.Lost total number ：
UI document：

Actual:

3.When description is long UI shows abnormal:

4.Click anywhere in record line can pop up cell detail window actually ,but in expect only click detail icon can pop up cell detail window.

2023-10-13.09.47.18.mov

5.When lock cell it shows warn:

but actually after lock cell ,then spend icon is not gray and can jump to send page ,send transaction successfully.

2023-10-13.10.17.18.mov

6.When click locked balance it jump to cell management page which include locked cell and unlocked cell,may be jump to locked cell page is better.

7.Locked reason does not show like this is requirement document:

Actual:

yanguoyu · 2023-10-13T02:41:27Z

but actually after lock cell ,then spend icon is not gray and can jump to send page ,send transaction successfully.

IMO, it can not be used on others' pages, but I can use this cell in the cell manage page. @Danie0918 Can we use the manually locked cells in the cell manage page?

When click locked balance it jump to cell management page which include locked cell and unlocked cell,may be jump to locked cell page is better.

Neuron does not have a page that only shows locked cells, what do you think? @Danie0918

7 .Locked reason does not show like this is requirement document:

Because of some cells are default locked, their locked reasons are different.

silySuper · 2023-10-13T02:46:49Z

To N0.7 issue ,my lock reason is same to requirement document,because I have sent a locktime transaction，requirement description is more clear than actual description.

Danie0918 · 2023-10-13T02:53:06Z

but actually after lock cell ,then spend icon is not gray and can jump to send page ,send transaction successfully.

IMO, it can not be used on others' pages, but I can use this cell in the cell manage page. @Danie0918 Can we use the manually locked cells in the cell manage page?

Manually locked cells can't be spent.

When click locked balance it jump to cell management page which include locked cell and unlocked cell,may be jump to locked cell page is better.

Neuron does not have a page that only shows locked cells, what do you think? @Danie0918

Instead of adding a separate page, you can optimize it a bit by sorting by default to show the locked cells first.By the way, sorting is still in effect when there are no locked cells.

yanguoyu · 2023-10-13T02:55:22Z

Instead of adding a separate page, you can optimize it a bit by sorting by default to show the locked cells first.By the way, sorting is still in effect when there are no locked cells.

Do you mean when I click the locked balance, then Neuorn should go to the cell manage page, and set default sort by locked field? @Danie0918 cc @silySuper

yanguoyu · 2023-10-13T02:59:27Z

To N0.7 issue ,my lock reason is same to requirement document,because I have sent a locktime transaction，requirement description is more clear than actual description.

@Danie0918 Do we have tips for different default-locked cells? Currently, I remind users to operate the locked cells on the corresponding page.

Danie0918 · 2023-10-13T03:00:23Z

Do we have tips for different default-locked cells? Currently, I remind users to operate the locked cells on the corresponding page.

Yes.

yanguoyu · 2023-10-13T03:02:20Z

Do we have tips for different default-locked cells? Currently, I remind users to operate the locked cells on the corresponding page.

Yes.

Where can I find the tips for different default-locked cells?

silySuper · 2023-10-13T03:11:44Z

8.Type field in overview page is different from history page at the same transaction.

Danie0918 · 2023-10-13T03:12:28Z

Do we have tips for different default-locked cells? Currently, I remind users to operate the locked cells on the corresponding page.

Yes.

Where can I find the tips for different default-locked cells?

Are we currently without relevant tips? This hint in the requirements is what I found in the custom assets.

yanguoyu · 2023-10-13T03:16:17Z

Do we have tips for different default-locked cells? Currently, I remind users to operate the locked cells on the corresponding page.

Yes.

Where can I find the tips for different default-locked cells?

Are we currently without relevant tips? This hint in the requirements is what I found in the custom assets.

Currently, I remind users to operate the locked cells on the corresponding page.

Where can I find the tips for different default-locked cells?

I mean where can I find the document that describes tips content for different default-locked cells?

Danie0918 · 2023-10-13T03:21:17Z

I mean where can I find the document that describes tips content for different default-locked cells?

Currently it's not, my hints in the documentation are just examples.

If we don't have a default prompt, we may need to organize the use cases and then I'll provide the documentation.

silySuper · 2023-10-13T07:20:34Z

9.Order by status is opposite to icon.

yanguoyu · 2023-10-13T07:25:07Z

9.Order by status is opposite to icon.

Order by status ASC, unlock cell will before than locked cell.

silySuper · 2023-10-13T07:29:27Z

9.Order by status is opposite to icon.

Order by status ASC, unlock cell will before than locked cell.

Does it not order by English alphabet？In English alphabet L is before U,I see that order by type field satisfy English alphabet.

yanguoyu · 2023-10-13T07:31:38Z

1.类型-CKB, UDT, NTF, Unknown
2.状态-解锁, 锁定
@silySuper S

yanguoyu · 2023-10-16T00:44:43Z

I mean where can I find the document that describes tips content for different default-locked cells?

Currently it's not, my hints in the documentation are just examples.

If we don't have a default prompt, we may need to organize the use cases and then I'll provide the documentation.

There are these default lock types:

lock script
- Cheque
- multisig-lock-time
- multisig
- anyone-can-pay
- unknown
type script
- nft
- nft-issue
- nft-class
- sudt
- dao
- unknown

yanguoyu · 2023-10-16T01:10:55Z

1, 2, 3, 4, 5, 6 have been fixed by nervosnetwork/neuron@8e3abb5 on the nervosnetwork/neuron#2859

yanguoyu · 2023-10-16T03:16:29Z

8.Type field in overview page is different from history page at the same transaction.

It's an issue on the develop branch, I opened a new PR to fix it. nervosnetwork/neuron#2876

silySuper · 2023-10-17T07:10:54Z

9.Batch locking cells can be unlocked again after unlocking.

2023-10-17.10.36.46.mov

10.Batch consume send balance is not fit for max balance.

2023-10-17.10.55.26.mov

yanguoyu · 2023-10-17T07:18:00Z

9.Batch locking cells can be unlocked again after unlocking.

I guess it's normal, otherwise if users want to lock or unlock all cells, they should pick one by one. What do you think? @Danie0918

silySuper · 2023-10-17T07:28:23Z

10.Batch locking cells can be unlocked again after unlocking.

I guess it's normal, otherwise if users want to lock or unlock all cells, they should pick one by one. What do you think? @Danie0918

To No.10 issue,another operation is the same result.Maybe judge status is better.

2023-10-17.15.25.26.mov

silySuper · 2023-10-17T07:38:14Z

12.If I chosed cells include both locked and unlocked status.The balance in lock pop up window and in unlock pop up window show abnormal.In expect ,lock balance is about 236712,unlock balance is about 1513.8.

2023-10-17.15.29.21.2.mov

yanguoyu · 2023-10-17T08:41:50Z

9.Batch locking cells can be unlocked again after unlocking.

I guess it's normal, otherwise if users want to lock or unlock all cells, they should pick one by one. What do you think? @Danie0918

To No.9 issue,another operation is the same result.Maybe judge status is better.
2023-10-17.15.25.26.mov

It may be a bit weird for the user, when the operation is not valid.

For batch operations, if all of them are unlocked or locked, the corresponding operations should be disabled.A batch operation should operate normally only if it can have a target to execute.

This means that when the cells selected in a batch are all unlocked, then the unlock operation should be disabled unless it contains cells that can be unlocked.

Again this applies to the lock.

If users select locked and unlocked cells, could they batch lock or unlock these cells?

Danie0918 · 2023-10-17T08:45:23Z

9.Batch locking cells can be unlocked again after unlocking.

I guess it's normal, otherwise if users want to lock or unlock all cells, they should pick one by one. What do you think? @Danie0918

To No.9 issue,another operation is the same result.Maybe judge status is better.
2023-10-17.15.25.26.mov

It may be a bit weird for the user, when the operation is not valid.
For batch operations, if all of them are unlocked or locked, the corresponding operations should be disabled.A batch operation should operate normally only if it can have a target to execute.
This means that when the cells selected in a batch are all unlocked, then the unlock operation should be disabled unless it contains cells that can be unlocked.
Again this applies to the lock.

If users select locked and unlocked cells, could they batch lock or unlock these cells?

This is possible because unlock and lock can be applied to some of the cells.

silySuper · 2023-10-17T09:03:56Z

1.Verified
2.Verified
3.Verified
4.Verified
5.Although after lock cell ,then spend icon is gray，but it can jump to send page ,send transaction successfully.

2023-10-17.16.59.36.2.mov

6.Verified
8.Verified

yanguoyu · 2023-10-18T09:03:12Z

10.Batch consume send balance is not fit for max balance.

IMO, when consuming some cells on the send page, clicking max will cost all of the selected cells. Or send the max of the wallet? @Danie0918 cc @silySuper

Danie0918 · 2023-10-18T12:32:52Z

10.Batch consume send balance is not fit for max balance.

IMO, when consuming some cells on the send page, clicking max will cost all of the selected cells. Or send the max of the wallet? @Danie0918 cc @silySuper

Here the consume should be brought to the maximum value of the selected cell without the user manually clicking on max.

yanguoyu · 2023-10-18T12:35:01Z

10.Batch consume send balance is not fit for max balance.

IMO, when consuming some cells on the send page, clicking max will cost all of the selected cells. Or send the max of the wallet? @Danie0918 cc @silySuper

Here the consume should be brought to the maximum value of the selected cell without the user manually clicking on max.

Okay, so the max value is the selected cells's total capacity but not wallet's total capacity.

yanguoyu · 2023-10-19T02:25:49Z

12.If I chosed cells include both locked and unlocked status.The balance in lock pop up window and in unlock pop up window show abnormal.In expect ,lock balance is about 236712,unlock balance is about 1513.8.

The title is unlocked balance, which means that total cell capacity will be unlocked. But not the current unlocked capacity.
I guess we should show all of the selected cells's capacity, what do you think? @Danie0918

yanguoyu · 2023-10-19T02:26:34Z

5,9 have been fixed. @silySuper

silySuper · 2023-10-19T02:31:42Z

I want to regress in full node mode，but app always shows

This is my log:
neuron_debug_1697682768607.zip

yanguoyu · 2023-10-19T02:37:21Z

I want to regress in full node mode，but app always shows

This is my log: neuron_debug_1697682768607.zip

This is the log.

[2023-10-19 10:18:04.066] [error] Sync:ChildProcess: /private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/6C3F7234-9F9D-4D63-8FB0-9E95D4E8F132/d/Neuron 2.app/Contents/Resources/app.asar/node_modules/@ckb-lumos/rpc/lib/method.js:73
          throw new _exceptions.ResponseException(JSON.stringify(res.data.error));
                ^

ResponseException [Error]: {"code":-4,"message":"RPCModuleIsDisabled: This RPC method is in the module `Indexer`. Please modify `rpc.modules` in ckb.toml and restart the ckb node to enable it."}

It means you need to start ckb with --indexer, but the Neuron should show a dialog to notify users, I will check why the dialog is not shown.

Danie0918 · 2023-10-19T02:39:56Z

12.If I chosed cells include both locked and unlocked status.The balance in lock pop up window and in unlock pop up window show abnormal.In expect ,lock balance is about 236712,unlock balance is about 1513.8.

The title is unlocked balance, which means that total cell capacity will be unlocked. But not the current unlocked capacity. I guess we should show all of the selected cells's capacity, what do you think? @Danie0918

Sure, all of the selected cells's capacity should be shown here.

silySuper · 2023-10-19T07:08:18Z

12.If I chosed cells include both locked and unlocked status.The balance in lock pop up window and in unlock pop up window show abnormal.In expect ,lock balance is about 236712,unlock balance is about 1513.8.

The title is unlocked balance, which means that total cell capacity will be unlocked. But not the current unlocked capacity. I guess we should show all of the selected cells's capacity, what do you think? @Danie0918

Sure, all of the selected cells's capacity should be shown here.

It means that only show all of the selected cells's capacity when batch lock or unlock ,and not distinguish lock or unlock cell in this window? @Danie0918

yanguoyu · 2023-10-19T08:47:37Z

I want to regress in full node mode，but app always shows
This is my log: neuron_debug_1697682768607.zip

This is the log.
[2023-10-19 10:18:04.066] [error] Sync:ChildProcess: /private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/6C3F7234-9F9D-4D63-8FB0-9E95D4E8F132/d/Neuron 2.app/Contents/Resources/app.asar/node_modules/@ckb-lumos/rpc/lib/method.js:73
          throw new _exceptions.ResponseException(JSON.stringify(res.data.error));
                ^

ResponseException [Error]: {"code":-4,"message":"RPCModuleIsDisabled: This RPC method is in the module `Indexer`. Please modify `rpc.modules` in ckb.toml and restart the ckb node to enable it."}
It means you need to start ckb with --indexer, but the Neuron should show a dialog to notify users, I will check why the dialog is not shown.

I have added a log when checking the external ckb node. You can package and try again without --indexer and wait for about 30s, if the dialog also can not show, upload the log again, then I will try to fix it. @silySuper

Danie0918 · 2023-10-19T11:53:23Z

12.If I chosed cells include both locked and unlocked status.The balance in lock pop up window and in unlock pop up window show abnormal.In expect ,lock balance is about 236712,unlock balance is about 1513.8.

The title is unlocked balance, which means that total cell capacity will be unlocked. But not the current unlocked capacity. I guess we should show all of the selected cells's capacity, what do you think? @Danie0918

Sure, all of the selected cells's capacity should be shown here.

It means that only show all of the selected cells's capacity when batch lock or unlock ,and not distinguish lock or unlock cell in this window? @Danie0918

Yes, no distinction is made here.

silySuper · 2023-10-23T01:36:52Z

5.Verified
10.Verified.

Danie0918 · 2023-10-23T10:35:14Z

anyone-can-pay

This can be categorized as follows:

[Lock time] The cell has a time lock and you can't use it until 2023-09-05.
[Lockscript ] This is a Cheque/ACP/Multisig cell and does not support unlocking.
[Typescript ] This is a NFT/SUDT/Nervos DAO asset and does not support unlocking.
[Unkonw] This is an uncataloged asset,please check and confirm before proceeding.

yanguoyu · 2023-10-29T01:21:21Z

[Lock time] The cell has a time lock and you can't use it until 2023-09-05.

@Danie0918 Sometimes this cell has reached the unlock time, but the user does not unlock it. Do you think we should change to another tip with this condition?

Danie0918 · 2023-10-30T09:05:07Z

[Lock time] The cell has a time lock and you can't use it until 2023-09-05.

@Danie0918 Sometimes this cell has reached the unlock time, but the user does not unlock it. Do you think we should change to another tip with this condition?

[Lock time - expires ] The time lock for this cell has expired and you need to claim it in Customized Assets before using it.

yanguoyu · 2023-11-20T00:44:01Z

@silySuper Please verify the left issues with the latest package.

silySuper · 2023-11-22T09:37:00Z

1.No.10 Batch consume send balance is not fit for max balance does not need to change? @Danie0918
2.No.7
(1).verified
(2).verified
(3).Send NFT successful,but cell mangement shows type is unknown.

2023-11-22.17.31.50.2.mov

(4).verified

yanguoyu · 2023-11-22T11:16:10Z

Send NFT successful,but cell mangement shows type is unknown.

The Spore type has been adapted.

No.10 Batch consume send balance is not fit for max balance does not need to change?

I can't get the point. Does the batch consume not send max?

2023-11-22.19.13.07.mov

silySuper · 2023-11-23T02:34:03Z

Send NFT successful,but cell mangement shows type is unknown.

The Spore type has been adapted.

No.10 Batch consume send balance is not fit for max balance does not need to change?

I can't get the point. Does the batch consume not send max?

2023-11-22.19.13.07.mov

here need change to chosed balance ,the same to send page ?

yanguoyu · 2023-11-23T02:36:17Z

Send NFT successful,but cell mangement shows type is unknown.

The Spore type has been adapted.

No.10 Batch consume send balance is not fit for max balance does not need to change?

I can't get the point. Does the batch consume not send max?
2023-11-22.19.13.07.mov

here need change to chosed balance ,the same to send page ?

@Danie0918

Danie0918 · 2023-11-23T02:41:07Z

1.No.10 Batch consume send balance is not fit for max balance does not need to change? @Danie0918 2.No.7 (1).verified

Send NFT successful,but cell mangement shows type is unknown.

The Spore type has been adapted.

No.10 Batch consume send balance is not fit for max balance does not need to change?

I can't get the point. Does the batch consume not send max?
2023-11-22.19.13.07.mov

here need change to chosed balance ,the same to send page ?

@Danie0918

This does lead to some misunderstandings, can we hide the balance in this case? @yanguoyu

yanguoyu · 2023-11-23T03:05:36Z

This does lead to some misunderstandings, can we hide the balance in this case?

It has been hidden when spending appointed cells. @silySuper

silySuper added the bug Something isn't working label Oct 13, 2023

silySuper assigned Danie0918 Oct 13, 2023

silySuper added this to Neuron Oct 13, 2023

Danie0918 assigned yanguoyu and unassigned Danie0918 Oct 13, 2023

Danie0918 moved this to 👀 Testing in Neuron Oct 13, 2023

silySuper mentioned this issue Oct 13, 2023

feat: Cell manage nervosnetwork/neuron#2859

Merged

Danie0918 assigned silySuper Oct 16, 2023

Danie0918 self-assigned this Oct 23, 2023

yanguoyu mentioned this issue Oct 30, 2023

Support click max when the receiver is not enter on the send page #308

Closed

Danie0918 moved this from 👀 Testing to 🚩Pre Release in Neuron Nov 27, 2023

Danie0918 moved this from 🚩Pre Release to ✅ Done in Neuron Jan 13, 2024

Danie0918 closed this as completed Mar 19, 2024

Issues of cell management testing #298

Issues of cell management testing #298

Comments

silySuper commented Oct 13, 2023 • edited Loading

yanguoyu commented Oct 13, 2023 • edited Loading

silySuper commented Oct 13, 2023

Danie0918 commented Oct 13, 2023

yanguoyu commented Oct 13, 2023 • edited Loading

yanguoyu commented Oct 13, 2023

Danie0918 commented Oct 13, 2023

yanguoyu commented Oct 13, 2023

silySuper commented Oct 13, 2023

Danie0918 commented Oct 13, 2023

yanguoyu commented Oct 13, 2023

Danie0918 commented Oct 13, 2023

silySuper commented Oct 13, 2023

yanguoyu commented Oct 13, 2023

silySuper commented Oct 13, 2023

yanguoyu commented Oct 13, 2023

yanguoyu commented Oct 16, 2023

yanguoyu commented Oct 16, 2023 • edited Loading

yanguoyu commented Oct 16, 2023

silySuper commented Oct 17, 2023 • edited Loading

yanguoyu commented Oct 17, 2023

silySuper commented Oct 17, 2023 • edited Loading

silySuper commented Oct 17, 2023

yanguoyu commented Oct 17, 2023

Danie0918 commented Oct 17, 2023

silySuper commented Oct 17, 2023

yanguoyu commented Oct 18, 2023

Danie0918 commented Oct 18, 2023

yanguoyu commented Oct 18, 2023

yanguoyu commented Oct 19, 2023

yanguoyu commented Oct 19, 2023

silySuper commented Oct 19, 2023 • edited Loading

yanguoyu commented Oct 19, 2023

Danie0918 commented Oct 19, 2023

silySuper commented Oct 19, 2023

yanguoyu commented Oct 19, 2023

Danie0918 commented Oct 19, 2023

silySuper commented Oct 23, 2023 • edited Loading

Danie0918 commented Oct 23, 2023

yanguoyu commented Oct 29, 2023

Danie0918 commented Oct 30, 2023

yanguoyu commented Nov 20, 2023

silySuper commented Nov 22, 2023

yanguoyu commented Nov 22, 2023

silySuper commented Nov 23, 2023

yanguoyu commented Nov 23, 2023

Danie0918 commented Nov 23, 2023

yanguoyu commented Nov 23, 2023

silySuper commented Oct 13, 2023 •

edited

Loading

yanguoyu commented Oct 13, 2023 •

edited

Loading

yanguoyu commented Oct 13, 2023 •

edited

Loading

yanguoyu commented Oct 16, 2023 •

edited

Loading

silySuper commented Oct 17, 2023 •

edited

Loading

silySuper commented Oct 17, 2023 •

edited

Loading

silySuper commented Oct 19, 2023 •

edited

Loading

silySuper commented Oct 23, 2023 •

edited

Loading