Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The multisig address's balance is not correct after send some txs with light client. #185

Closed
yanguoyu opened this issue Jun 9, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@yanguoyu
Copy link

yanguoyu commented Jun 9, 2023

What happened

Because the light client API https://github.com/nervosnetwork/ckb-light-client#get_transactions has some differences with ckb node. So we need to change the getter of tx_hash when the node is light client at https://github.com/nervosnetwork/neuron/blob/v0.110.1/packages/neuron-wallet/src/services/multisig.ts#L191. Otherwise Neuron can not remove dead cell with multisig address with the light client.

@yanguoyu yanguoyu self-assigned this Jun 9, 2023
@yanguoyu
Copy link
Author

yanguoyu commented Jun 9, 2023

@yanguoyu yanguoyu added the bug Something isn't working label Jun 13, 2023
@yanguoyu yanguoyu added this to Neuron Jun 13, 2023
@yanguoyu yanguoyu moved this to 👀 Testing in Neuron Jun 13, 2023
@Danie0918 Danie0918 assigned FrederLu and unassigned yanguoyu Jun 19, 2023
@littleLip520
Copy link

blocked by issue #196

@yanguoyu
Copy link
Author

You can test it by sending a tx from multisig address to another address.

@littleLip520
Copy link

verified

@github-project-automation github-project-automation bot moved this from 👀 Testing to ✅ Done in Neuron Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants