Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add checks for DAG where relevant in GraphicalModels #204

Open
olgakuznetsova opened this issue Nov 9, 2020 · 2 comments
Open

add checks for DAG where relevant in GraphicalModels #204

olgakuznetsova opened this issue Nov 9, 2020 · 2 comments
Assignees
Labels
GraphicalModels Issues related to package "GraphicalModels"

Comments

@olgakuznetsova
Copy link

No description provided.

@olgakuznetsova olgakuznetsova added the GraphicalModels Issues related to package "GraphicalModels" label Nov 9, 2020
@olgakuznetsova olgakuznetsova changed the title globalMarkov add check for DAG Future: add checks for DAG where relevant in GraphicalModels Nov 9, 2020
@olgakuznetsova olgakuznetsova changed the title Future: add checks for DAG where relevant in GraphicalModels add checks for DAG where relevant in GraphicalModels Nov 9, 2020
@olgakuznetsova
Copy link
Author

globalMarkov add check for DAG

•	!pairMarkov - Graph or Digraph (checks for DAG)
•	l!ocalMarkov - Graph or Digraph (checks for DAG)
•	!globalMarkov - Graph or Digraph (does not check for DAG)
•	!markovRing - Sequence
•	!gaussianRing- ZZ or Graph or Digraph or MixedGraph (doesn’t check for DAG)
•	!markovMatrices - (Ring,List,List) or (Ring, List) check that it is a Markov ring
•	!covarianceMatrix - Ring, checks that is a Gaussian Ring
•	conditionalIndependenceIdeal - (Ring, List) or (Ring, List, List), checks whether ring is Gaussian or Markov. In the case of (Ring, List, List), only takes Markov rings
•	gaussianParametrization- Ring, checks that is Gaussian ring of MixedGraph without undirected edges
•	gaussianVanishingIdeal - Ring, checks that this is a Gaussian ring go Graph or Digraph or MixedGraph without undirected part
•	!discreteVanishingIdeal - (Ring, Digraph), checks that ring is Markov and the number of vertices is compatible but not that the graph is a Digraph
•	trekSeparation - MixedGraph, checks that there are no undirected edges but does not check that this is a MixedGraph or that both Digraph and Bigraph are present
•	trekIdeal - (Ring,G), where G can be Graph, Digraph or MixedGraph with directed and bidirected edges. Does not check that G has correct type but checks compatibility of variable names in the Ring and G
•	marginMap - (ZZ,Ring), checks that ZZ is compatible with the Ring and that Ring is a MarkovRing
•	inverseMarginMap- (ZZ,Ring), checks that ZZ is compatible with the Ring and that Ring is a MarkovRing
•	hiddenMap - (ZZ,Ring), checks that ZZ is compatible with the Ring and that Ring is a MarkovRing
•	identifyParameters

@roserhp
Copy link

roserhp commented Nov 10, 2020

  • globalMarkov: added check for DAG
  • gaussianMatrices
  • conditionalIndependenceIdeal: in case we want to add a check, it is enough to add a check in gaussianMatrices
  • gaussianVanishingIdeal: already checks directed part is acyclic
  • gaussianParametrization
  • trekSeparation
  • trekIdeal: in case we want to add a check, it is enough to add a check in trekSeparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GraphicalModels Issues related to package "GraphicalModels"
Projects
None yet
Development

No branches or pull requests

2 participants