Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python < 3.8 #229

Closed
afuetterer opened this issue Jun 6, 2024 · 5 comments
Closed

Drop support for Python < 3.8 #229

afuetterer opened this issue Jun 6, 2024 · 5 comments

Comments

@afuetterer
Copy link
Contributor

I suggest giving this project the same treatment as Bertopic:

  • drop Python 3.6-3.7
  • add support for 3.8-3.12

See MaartenGr/BERTopic#1942

@MaartenGr
Copy link
Owner

MaartenGr commented Jun 8, 2024

@afuetterer Thanks, totally agree! Aside from security/support reasons, the number of users using Python < 3.8 is also low.

@afuetterer
Copy link
Contributor Author

Already opened #230.

Migration to pyproject.toml as well?

@MaartenGr
Copy link
Owner

@afuetterer Yeah, that would be great. But again, only if you have the time, don't want to ask too much of you 😉

@afuetterer
Copy link
Contributor Author

afuetterer commented Jun 8, 2024

Sure thing.

Actually even if you don't want to use hatch/hatchling as the build backend. You can use hatch to migrate from setup.py to pyproject.toml pretty easily.

git clone https://github.com/MaartenGr/KeyBERT.git
cd KeyBERT
hatch new --init

Some tweaks here and there, but the basic skeleton is alright. For example it wants to sort keywords alphabetically.

@afuetterer
Copy link
Contributor Author

Done via #230.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants