Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Matlab Functionalities to Python #80

Open
TristanHehnen opened this issue Sep 17, 2020 · 2 comments
Open

Translate Matlab Functionalities to Python #80

TristanHehnen opened this issue Sep 17, 2020 · 2 comments

Comments

@TristanHehnen
Copy link
Contributor

This issue is based on a comment by Randy, where the idea was expressed to translate the Matlab functionalities provided with this repository to Python.

I think further discussions on this task should have their own place here.

@rmcdermo
Copy link
Contributor

@TristanHehnen Your comment about working on the foundation is a good one. I have already built plotting scripts here that I plan to start using for macfp-db. This Python module follows the idea of "dataplot" that we use in the FDS validation suite. Ultimately, each line on a plot is a line in a .csv master configuration file that defines the plotting parameters. Of course, validation metrics can be processed, and further statistical analysis can be built into the scripts as needed. In FDS, this is done with "scatterplot".

In FDS, this is all done in Matlab. Over the years it has evolved and, of course, it is not perfect. But what I've learned from my experience with the 2017 gas phase MaCFP and now with the Mablab scripts that have been put together for matl-db (which are similar to the ones I did in 2017) is that the master config file idea is more robust.

If a dictionary is a cleaner way to store the information, let's discuss this offline. I have not yet worked with a large dictionary. Thanks

@TristanHehnen
Copy link
Contributor Author

As a brief notification: We are now slowly starting with the translation of the matlab functionality into Python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants