Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add Task Group: Create New App Onboarding Release pipeline changes" needs some updates #6

Open
JayD123 opened this issue Mar 24, 2020 · 0 comments

Comments

@JayD123
Copy link

JayD123 commented Mar 24, 2020

Few updates can be made to the "Add Task Group: Create New App Onboarding Release pipeline"

  1. The definition id passed is 2 assuming that the definition id 2 exists since 1 is the empty release pipeline and 2 is the Initial Mendix setup pipeline. This might not always be the case if it is a project which had these release pipelines cleaned up and newer ones created. Azure Dev Ops doesn't claim a deleted definition id it just does max+1. In this case it would throw a 404, release pipeline doesn't exist error.
  2. How about passing 0 based on the Azure Dev Ops recommendation as listed in their documentation https://docs.microsoft.com/en-us/rest/api/azure/devops/release/definitions/create?view=azure-devops-rest-5.1 . This will then auto-generate a defintion with the next sequence number for definition id
  3. This I am not too sure but from what I understand we don't need to pass the url and links (which references the wrong release pipeline) as this would be generated as a part of response "Release definition"
	"url": "https://vsrm.dev.azure.com/mxclydedemo/01a29e90-f89b-4f9f-b1ea-2e845b5f3cb2/_apis/Release/definitions/2",
	"_links": {
		"self": {
			"href": "https://vsrm.dev.azure.com/mxclydedemo/01a29e90-f89b-4f9f-b1ea-2e845b5f3cb2/_apis/Release/definitions/2"
		},
		"web": {
			"href": "https://dev.azure.com/mxclydedemo/01a29e90-f89b-4f9f-b1ea-2e845b5f3cb2/_release?definitionId=2"
		}
	}
  1. Finally it is no longer in preview so instead of passing /release/definitions?api-version=5.1-preview.3 we can pass /release/definitions?api-version=5.1 but Azure Dev Ops would still handle the redirection even if we did pass the preview version

Reference - Line No 807 https://github.com/MXClyde/mendix-kubernetes-azure/blob/master/manifests/azuredevops/Initial%20Mendix%20Setup.json#L807

Thanks again Clyde for this awesome piece of documentation

Abe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant