Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arange improvements #16

Open
vkhodygo opened this issue May 19, 2022 · 0 comments
Open

Arange improvements #16

vkhodygo opened this issue May 19, 2022 · 0 comments
Assignees

Comments

@vkhodygo
Copy link
Member

  • Current class structure is suitable for testing, but having a function that is package-private feels wrong as it has no checks: all of them are done earlier;
  • Use some sort of isclose instead of generic == for comparison of doubles;
  • add checks for sets of parameters that have different ranges (potential overflow/underflow):
    • small step and (large) interval might lead to overflow;
    • small interval and (large) step might lead to underflow;
    • small interval and and small step might lead to NaN.
@vkhodygo vkhodygo self-assigned this May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant