Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code refactoring/docs/tests #4

Open
4 tasks
vkhodygo opened this issue Jun 20, 2022 · 3 comments
Open
4 tasks

Code refactoring/docs/tests #4

vkhodygo opened this issue Jun 20, 2022 · 3 comments
Assignees
@vkhodygo
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@vkhodygo
Copy link
Member

  • Reduce the size
  • Introduce more general functions, no hardcoded names
  • Add docstrings
  • Add tests
@vkhodygo vkhodygo added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 20, 2022
@vkhodygo vkhodygo self-assigned this Jun 20, 2022
@vkhodygo
Copy link
Member Author

@andrewbaxter439

How good are your R testing skills? I'd like to write some, but my experience with functional languages and R in particular is limited.
I also have a suspicion I need to modify the code to follow some conventions and make it more well-structured.

@andrewbaxter439
Copy link
Member

I would say that I get the principles of testing, can understand functional languages and can apply testing using testthat to R function outputs, but thus far haven't paid it much attention! Would it be useful to chat over what tests would most suitably be used?

@vkhodygo
Copy link
Member Author

That sounds good, designing everything in advance seems to be practical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vkhodygo vkhodygo

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vkhodygo @andrewbaxter439