Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToDos #18

Open
11 of 13 tasks
AtiyahElsheikh opened this issue Sep 27, 2023 · 1 comment
Open
11 of 13 tasks

ToDos #18

AtiyahElsheikh opened this issue Sep 27, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@AtiyahElsheikh
Copy link
Collaborator

AtiyahElsheikh commented Sep 27, 2023 •
edited
Loading

expanding the parameter space causes simulation errors that need to be fixed:

  • fix seed
  • bugs due to expansion of the parameter space
    • ArgumentError: weights cannot contain Inf or NaN values (domarriages) -- due to high number of children
    • person to marry not the oldest within his/her household (probably due to step siblings) -- temporary solution till missing consistency checking  #7
    • people may live much longer and input data is ready only till age 160 - temporary solution
    • no single women available causes errors for marriages
    • Formula for death rate lead to errors -- adhoc solution
    • Morris indices w.r.t. the output ratio of children in population produce Inf or Nan - error was due to relative scaling
  • bugs / inaccuracies related to multithreading
    • global variables cause troubles in multithreading environments
    • non-deterministic behaviour due to default random number generator depending on hidden global variable -- random number generation allows reproducibility in multithreading environment
    • global variables may impact runtime performance in multithreading
    • at least in OAT algorithm, different number of threads deliver different results (p.s. the different results are still correct due to nondeterminism across different number of threads, but the behaviour remains deterministic with the same number of threads)
@AtiyahElsheikh AtiyahElsheikh added the enhancement New feature or request label Sep 27, 2023
@AtiyahElsheikh AtiyahElsheikh mentioned this issue Nov 3, 2023
Open
5 tasks
@AtiyahElsheikh
Copy link
Collaborator Author

  • removing agents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AtiyahElsheikh