From 0f411a900c2e36cf16371b344b4c6ddf25c5e44f Mon Sep 17 00:00:00 2001 From: Jeff Jennings Date: Thu, 9 Feb 2023 03:02:41 -0500 Subject: [PATCH 1/3] GriddedDataset: torch warn fix --- src/mpol/datasets.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mpol/datasets.py b/src/mpol/datasets.py index 10925a65..ab189ce8 100644 --- a/src/mpol/datasets.py +++ b/src/mpol/datasets.py @@ -101,7 +101,10 @@ def add_mask( device (torch.device) : the desired device of the dataset. If ``None``, defalts to current device. """ - new_2D_mask = torch.tensor(mask, device=device) + if torch.is_tensor(mask): + new_2D_mask = mask.clone().detach().to(device) + else: + new_2D_mask = torch.tensor(mask, device=device) new_3D_mask = torch.broadcast_to(new_2D_mask, self.mask.size()) # update mask via an AND operation, meaning we will only keep visibilities that are From 17db0a61023e86cd531d314f54e8af4264d5d666 Mon Sep 17 00:00:00 2001 From: Jeff Jennings Date: Thu, 9 Feb 2023 03:28:16 -0500 Subject: [PATCH 2/3] induce tests --- .github/workflows/tests.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 0049c253..4c3579fe 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -2,10 +2,8 @@ name: package test on: pull_request_target: - paths: - - '*.*' + types: [opened, synchronize, reopened] push: - branches: ['main'] jobs: dl_files: From 30ad09b6b47c23f8b1b13576f637d32544a22efd Mon Sep 17 00:00:00 2001 From: Kadri Nizam Date: Thu, 9 Feb 2023 15:18:37 -0500 Subject: [PATCH 3/3] Replace type check with direct Tensor call --- src/mpol/datasets.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/mpol/datasets.py b/src/mpol/datasets.py index ab189ce8..db430853 100644 --- a/src/mpol/datasets.py +++ b/src/mpol/datasets.py @@ -101,10 +101,7 @@ def add_mask( device (torch.device) : the desired device of the dataset. If ``None``, defalts to current device. """ - if torch.is_tensor(mask): - new_2D_mask = mask.clone().detach().to(device) - else: - new_2D_mask = torch.tensor(mask, device=device) + new_2D_mask = torch.Tensor(mask).detach().to(device) new_3D_mask = torch.broadcast_to(new_2D_mask, self.mask.size()) # update mask via an AND operation, meaning we will only keep visibilities that are